[GitHub] [arrow] westonpace commented on a change in pull request #12066: ARROW-15241: [C++] MakeArrayOfNull fails on extension types with a nested storage type

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #12066:
URL: https://github.com/apache/arrow/pull/12066#discussion_r778456397



##########
File path: cpp/src/arrow/array/util.cc
##########
@@ -511,6 +511,9 @@ class NullArrayFactory {
   }
 
   Status Visit(const ExtensionType& type) {
+    std::vector<std::shared_ptr<ArrayData>> child_data(type.storage_type()->num_fields());
+    out_ =
+        ArrayData::Make(type.storage_type(), length_, {buffer_}, child_data, length_, 0);

Review comment:
       Ah, thanks, you are correct.  I switched to that and added a check for the array's type to the unit test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org