You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "yx91490 (Jira)" <ji...@apache.org> on 2022/07/24 02:51:00 UTC
[jira] [Comment Edited] (IMPALA-11439) Add an environment variable to control bootstrap_system.sh whether to prepopulate the m2 directory or not
[ https://issues.apache.org/jira/browse/IMPALA-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570408#comment-17570408 ]
yx91490 edited comment on IMPALA-11439 at 7/24/22 2:50 AM:
-----------------------------------------------------------
Hi [~laszlog] , thanks a lot for your reply, I have some doubts about your comments:
# I didn't flip the default behavior, when user doesn't set the 'PREPOPULATE_M2_REPOSITORY' env variable, the bootstrap_system.sh will also download because of the bash grammar '${PREPOPULATE_M2_REPOSITORY:-true}'.
# This env variable was added to the bootstrap_system.sh, it only affects the bootstrap_system.sh but buildall.sh, and the bootstrap_system.sh will be executed before buildall.sh.
# Personally I don't like 'suppression-type' flag, because it is counterintuitive. there is another true or false flag named DOWNLOAD_CDH_COMPONENTS, so the naming rule in impala is inconsistent. But this is not a key problem, I can change it if most people like the 'suppression-type'.
Thanks for your reply again, and I'm looking forward to your final reply. :D
was (Author: yx91490):
Hi [~laszlog] , thanks a lot for your reply, I have some doubts about your comments:
# I didn't flip the default behavior, when user doesn't set the 'PREPOPULATE_M2_REPOSITORY' env variable, the bootstrap_system.sh will also download because of the bash grammar '${PREPOPULATE_M2_REPOSITORY:-true}'.
# This env variable was added to the bootstrap_system.sh, it only affects the bootstrap_system.sh but buildall.sh, and the bootstrap_system.sh will be executed before buildall.sh.
# Personally I don't like 'suppression-type' flag, because it is counterintuitive. there is another true or false flag named DOWNLOAD_CDH_COMPONENTS, so the naming rule in impala was not consistent. But this is not a key problem, I can change it if most people like the 'suppression-type'.
Thanks for your reply again, and I'm looking forward to your final reply. :D
> Add an environment variable to control bootstrap_system.sh whether to prepopulate the m2 directory or not
> ----------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-11439
> URL: https://issues.apache.org/jira/browse/IMPALA-11439
> Project: IMPALA
> Issue Type: Improvement
> Affects Versions: Impala 4.1.0
> Reporter: yx91490
> Assignee: yx91490
> Priority: Major
>
> Currently bootstrap_system.sh will prepopulate the .m2 directory by download a 800M+ archive file from jenkins.impala.io, this intended to speed up the maven package process, so it's not required. meanwhile, due to different network environment, the download speed of the archive file is not necessarily fast.
> I want to add an environment variable 'PREPOPULATE_M2_REPOSITORY' to control whether to prepopulate the m2 directory or not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org