You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ma...@apache.org on 2015/11/23 19:41:21 UTC
incubator-reef git commit: [REEF-1010] Fix wrong Jira issue reference
and add TODO triage in RoundTripTest
Repository: incubator-reef
Updated Branches:
refs/heads/master b795ae059 -> b0722e480
[REEF-1010] Fix wrong Jira issue reference and add TODO triage in RoundTripTest
This fixes the TODO comments with correct format and Jira issue ID.
JIRA:
[REEF-1010](https://issues.apache.org/jira/browse/REEF-1010)
Pull Request:
This closes #674
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/b0722e48
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/b0722e48
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/b0722e48
Branch: refs/heads/master
Commit: b0722e480677cdf9be1be8096188ac4eadbe1958
Parents: b795ae0
Author: Dongjoon Hyun <do...@apache.org>
Authored: Mon Nov 23 01:46:59 2015 +0900
Committer: Mariia Mykhailova <ma...@apache.org>
Committed: Mon Nov 23 10:40:00 2015 -0800
----------------------------------------------------------------------
.../src/test/java/org/apache/reef/tang/test/RoundTripTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b0722e48/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java
index 23d338e..c66fbba 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java
@@ -38,7 +38,7 @@ public abstract class RoundTripTest {
@Test
public void testRoundTrip() throws Exception {
- // TODO: use 'getConfiguration' instead of 'getConfigurationWithoutList' after #192 is fixed
+ // TODO[JIRA REEF-1009]: use 'getConfiguration' instead of 'getConfigurationWithoutList' after REEF-402 is fixed
final Configuration conf = ObjectTreeTest.getConfigurationWithoutList();
final RootInterface before = Tang.Factory.getTang().newInjector(conf).getInstance(RootInterface.class);
final RootInterface after = Tang.Factory.getTang().newInjector(roundTrip(conf)).getInstance(RootInterface.class);
@@ -47,7 +47,7 @@ public abstract class RoundTripTest {
@Test
public void testRoundTripWithClassHierarchy() throws Exception {
- // TODO: use 'getConfiguration' instead of 'getConfigurationWithoutList' after #192 is fixed
+ // TODO[JIRA REEF-1009]: use 'getConfiguration' instead of 'getConfigurationWithoutList' after REEF-402 is fixed
final Configuration confBefore = ObjectTreeTest.getConfigurationWithoutList();
final AvroClassHierarchySerializer chSerializer = new AvroClassHierarchySerializer();
final ClassHierarchy c = chSerializer.fromAvro(chSerializer.toAvro(confBefore.getClassHierarchy()));