You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/24 13:47:56 UTC

[GitHub] [apisix-website] iamayushdas opened a new pull request #385: fix: navigation path naming for apisix-java-plugin-runner

iamayushdas opened a new pull request #385:
URL: https://github.com/apache/apisix-website/pull/385


   Fixes: #[Add issue number here]
   
   Changes:
   
   fixed the navigation path name for apisix-java-plugin-runner
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r660002634



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       I know it will be confusing for many developers, thats why i wanted to add new features for uniform id's but spacewander was not happy with the idea, 
   
   You could visit this for your query - any please put your values opinion too
   
   https://github.com/apache/apisix-website/issues/363




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869337110


   @Yiyiyimu have a look again please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas edited a comment on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869287200






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869096670


   LGTM, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869296175


   > @iamayushdas you can check the preview page
   
   oops, we got a problem here
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-867652106


   cc @juzhiyuan @Yiyiyimu  
   till then that uniform id proposal did not pass this will work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-867650705


   :heavy_check_mark: Deploy Preview for *apisix* ready!
   
   
   :hammer: Explore the source changes: f32b61a93e957790a2e1d4844ca721ee062a7da0
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60d93fd20331c80007687fbe](https://app.netlify.com/sites/apisix/deploys/60d93fd20331c80007687fbe?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: [https://deploy-preview-385--apisix.netlify.app](https://deploy-preview-385--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu merged pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #385:
URL: https://github.com/apache/apisix-website/pull/385


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r659993045



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Its the id of page

##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       I know it will be confusing for many developers, thats why i wanted to add new features for uniform id's but spacewander was not happy with the idea, 
   
   You could visit this for your query - any please put your values opinion too
   
   

##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       I know it will be confusing for many developers, thats why i wanted to add new features for uniform id's but spacewander was not happy with the idea, 
   
   You could visit this for your query - any please put your values opinion too
   
   https://github.com/apache/apisix-website/issues/363




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu merged pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #385:
URL: https://github.com/apache/apisix-website/pull/385


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-867650705


   :construction_worker: Deploy Preview for *apisix* processing.
   
   
   :hammer: Explore the source changes: b95015251000f695ce9daefd0745b55dafff28b6
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60d48cfb28012300076e218a](https://app.netlify.com/sites/apisix/deploys/60d48cfb28012300076e218a?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869287200


   > > It seems I can not see `apisix-java-runner` in navbar, is that expected?
   > > ![image](https://user-images.githubusercontent.com/34589752/123569607-a2b78580-d794-11eb-8ac4-a2c2d4e8a3b4.png)
   > 
   > No, there should be apisix-java-runner, I think you have unmerged changes
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869285096


   > It seems I can not see `apisix-java-runner` in navbar, is that expected?
   > 
   > ![image](https://user-images.githubusercontent.com/34589752/123569607-a2b78580-d794-11eb-8ac4-a2c2d4e8a3b4.png)
   > 
   > 
   
   No, there should be apisix-java-runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869283413


   It seems I can not see `apisix-java-runner` in navbar, is that expected?
   ![image](https://user-images.githubusercontent.com/34589752/123569607-a2b78580-d794-11eb-8ac4-a2c2d4e8a3b4.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-867650705


   :construction_worker: Deploy Preview for *apisix* processing.
   
   
   :hammer: Explore the source changes: f32b61a93e957790a2e1d4844ca721ee062a7da0
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60d93fd20331c80007687fbe](https://app.netlify.com/sites/apisix/deploys/60d93fd20331c80007687fbe?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r660058808



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Got it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r659991522



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Hi @iamayushdas I'm not so familiar with this. What does this `overview` corresponding to?

##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Like this one?
   ![image](https://user-images.githubusercontent.com/34589752/123681146-7002a100-d817-11eb-96a1-a0992d3b8e6d.png)
   
   But it seems for other projects the list here is not corresponding to the link it jumps to like
   ![image](https://user-images.githubusercontent.com/34589752/123681242-958faa80-d817-11eb-9ee9-e5e7f93d05fe.png)
   

##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Got it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r660002634



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       I know it will be confusing for many developers, thats why i wanted to add new features for uniform id's but spacewander was not happy with the idea, 
   
   You could visit this for your query - any please put your values opinion too
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas removed a comment on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas removed a comment on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869285096


   > It seems I can not see `apisix-java-runner` in navbar, is that expected?
   > 
   > ![image](https://user-images.githubusercontent.com/34589752/123569607-a2b78580-d794-11eb-8ac4-a2c2d4e8a3b4.png)
   > 
   > 
   
   No, there should be apisix-java-runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-867650705


   :heavy_check_mark: Deploy Preview for *apisix* ready!
   
   
   :hammer: Explore the source changes: b95015251000f695ce9daefd0745b55dafff28b6
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60d48cfb28012300076e218a](https://app.netlify.com/sites/apisix/deploys/60d48cfb28012300076e218a?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: [https://deploy-preview-385--apisix.netlify.app](https://deploy-preview-385--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#issuecomment-869295777


   @iamayushdas you can check the preview page


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r659993045



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Its the id of page




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r659991522



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Hi @iamayushdas I'm not so familiar with this. What does this `overview` corresponding to?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #385: fix: navigation path naming for apisix-java-plugin-runner

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #385:
URL: https://github.com/apache/apisix-website/pull/385#discussion_r659997254



##########
File path: website/src/theme/DocPage/index.js
##########
@@ -32,8 +32,9 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
     apisix : "getting-started",
     apisixDashboard : "dashboard",
     apisixIngressController : "what-is-apisix-ingress-controller",
-    apisixHelmChart : "install",
-    apisixDocker : "build-an-image-from-source"
+    apisixHelmChart : "seeking-help",
+    apisixDocker : "build-an-image-from-source",
+    apisixJavaPluginRunner : "overview"

Review comment:
       Like this one?
   ![image](https://user-images.githubusercontent.com/34589752/123681146-7002a100-d817-11eb-96a1-a0992d3b8e6d.png)
   
   But it seems for other projects the list here is not corresponding to the link it jumps to like
   ![image](https://user-images.githubusercontent.com/34589752/123681242-958faa80-d817-11eb-9ee9-e5e7f93d05fe.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org