You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by agresch <gi...@git.apache.org> on 2018/12/05 17:28:23 UTC
[GitHub] storm pull request #2920: STORM-3297 prevent supervisor restart when no nimb...
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2920
STORM-3297 prevent supervisor restart when no nimbus leader exists
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm agresch_processWorkerMetrics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2920
----
commit d8e649d2139a7fb7e71c022a28eefd40f684308e
Author: Aaron Gresch <ag...@...>
Date: 2018-12-05T17:27:43Z
STORM-3297 prevent supervisor restart when no nimbus leader exists
----
---
[GitHub] storm issue #2920: STORM-3297 prevent supervisor restart when no nimbus lead...
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2920
@srdo - done
---
[GitHub] storm pull request #2920: STORM-3297 prevent supervisor restart when no nimb...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2920
---
[GitHub] storm pull request #2920: STORM-3297 prevent supervisor restart when no nimb...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2920#discussion_r239231045
--- Diff: storm-server/src/main/java/org/apache/storm/metricstore/NimbusMetricProcessor.java ---
@@ -24,7 +24,7 @@
public void processWorkerMetrics(Map<String, Object> conf, WorkerMetrics metrics) throws MetricException {
try (NimbusClient client = NimbusClient.getConfiguredClient(conf)) {
client.getClient().processWorkerMetrics(metrics);
- } catch (TException e) {
--- End diff --
Could we instead of handling all exceptions, be more specific on capturing `NimbusLeaderNotFoundException` ?
`catch (TException | NimbusLeaderNotFoundException e)`
---
[GitHub] storm issue #2920: STORM-3297 prevent supervisor restart when no nimbus lead...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2920
+1, please squash to one commit and I'll merge :)
---
[GitHub] storm pull request #2920: STORM-3297 prevent supervisor restart when no nimb...
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2920#discussion_r239235259
--- Diff: storm-server/src/main/java/org/apache/storm/metricstore/NimbusMetricProcessor.java ---
@@ -24,7 +24,7 @@
public void processWorkerMetrics(Map<String, Object> conf, WorkerMetrics metrics) throws MetricException {
try (NimbusClient client = NimbusClient.getConfiguredClient(conf)) {
client.getClient().processWorkerMetrics(metrics);
- } catch (TException e) {
--- End diff --
done
---