You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2013/04/18 16:42:07 UTC
svn commit: r1469350 - in
/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security:
principal/PrincipalManagerTest.java user/CreateUserTest.java
Author: angela
Date: Thu Apr 18 14:42:06 2013
New Revision: 1469350
URL: http://svn.apache.org/r1469350
Log:
minor improvement
Modified:
jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java
jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/CreateUserTest.java
Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java?rev=1469350&r1=1469349&r2=1469350&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java Thu Apr 18 14:42:06 2013
@@ -59,7 +59,6 @@ public class PrincipalManagerTest extend
}
private Principal[] getPrincipals(Credentials credentials) throws Exception {
- // TODO: improve
Set<Principal> principals = new HashSet<Principal>();
if (credentials instanceof SimpleCredentials) {
Principal p = principalMgr.getPrincipal(((SimpleCredentials) credentials).getUserID());
Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/CreateUserTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/CreateUserTest.java?rev=1469350&r1=1469349&r2=1469350&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/CreateUserTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/CreateUserTest.java Thu Apr 18 14:42:06 2013
@@ -225,7 +225,9 @@ public class CreateUserTest extends Abst
}
}
- // TODO: RepositoryException is thrown instead of AuthorizableExistsException
+ /**
+ * @since OAK 1.0 : RepositoryException is thrown instead of AuthorizableExistsException
+ */
public void testCreateTwiceWithSamePrincipal() throws RepositoryException, NotExecutableException {
Principal p = getTestPrincipal();
String uid = p.getName();