You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by David Blevins <da...@gmail.com> on 2011/07/09 04:40:57 UTC

Re: Patch for OPENEJB-1607 (CDI @Interceptor and @InterceptorBinding examples)

I've been incredibly busy with CDI integration.  Anyone have some spare bandwidth to review/commit this?

Thanks again, Vishwa!  And thanks for the patience :)

-David

On Jun 28, 2011, at 2:27 PM, stratwine wrote:

> Have deleted the old patch attachment and added a new one...
> Pls review.. :)
> 
> --
> View this message in context: http://openejb.979440.n4.nabble.com/Patch-for-OPENEJB-1607-CDI-Interceptor-and-InterceptorBinding-examples-tp3628768p3631504.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: Patch for OPENEJB-1607 (CDI @Interceptor and @InterceptorBinding examples)

Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Perfect Thanks Karan and Vishwa ;-)

2011/7/11 Karan Malhi <ka...@gmail.com>

> I did review it. Just closed the issue
>
> On Mon, Jul 11, 2011 at 4:29 AM, Jean-Louis MONTEIRO <je...@gmail.com>
> wrote:
> > Karan, did you start reviewing it?
> > Otherwise, as IntelliJ is now opened, I can review it for you.
> >
> > Jean-Louis
> >
> > 2011/7/9 stratwine <to...@gmail.com>
> >
> >> My bad, I created the patch when things looked fine with Eclipse. Note
> to
> >> self: Make sure maven gives a green :)
> >>
> >> Please take the modified patch -  ( cdi-interceptors-corrected.patch )
> >>
> >> Thanks,
> >> Vishwa
> >>
> >> --
> >> View this message in context:
> >>
> http://openejb.979440.n4.nabble.com/Patch-for-OPENEJB-1607-CDI-Interceptor-and-InterceptorBinding-examples-tp3628768p3656668.html
> >> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
> >>
> >
>
>
>
> --
>
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi
>

Re: Patch for OPENEJB-1607 (CDI @Interceptor and @InterceptorBinding examples)

Posted by Karan Malhi <ka...@gmail.com>.
I did review it. Just closed the issue

On Mon, Jul 11, 2011 at 4:29 AM, Jean-Louis MONTEIRO <je...@gmail.com> wrote:
> Karan, did you start reviewing it?
> Otherwise, as IntelliJ is now opened, I can review it for you.
>
> Jean-Louis
>
> 2011/7/9 stratwine <to...@gmail.com>
>
>> My bad, I created the patch when things looked fine with Eclipse. Note to
>> self: Make sure maven gives a green :)
>>
>> Please take the modified patch -  ( cdi-interceptors-corrected.patch )
>>
>> Thanks,
>> Vishwa
>>
>> --
>> View this message in context:
>> http://openejb.979440.n4.nabble.com/Patch-for-OPENEJB-1607-CDI-Interceptor-and-InterceptorBinding-examples-tp3628768p3656668.html
>> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>>
>



-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi

Re: Patch for OPENEJB-1607 (CDI @Interceptor and @InterceptorBinding examples)

Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Karan, did you start reviewing it?
Otherwise, as IntelliJ is now opened, I can review it for you.

Jean-Louis

2011/7/9 stratwine <to...@gmail.com>

> My bad, I created the patch when things looked fine with Eclipse. Note to
> self: Make sure maven gives a green :)
>
> Please take the modified patch -  ( cdi-interceptors-corrected.patch )
>
> Thanks,
> Vishwa
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/Patch-for-OPENEJB-1607-CDI-Interceptor-and-InterceptorBinding-examples-tp3628768p3656668.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Re: Patch for OPENEJB-1607 (CDI @Interceptor and @InterceptorBinding examples)

Posted by stratwine <to...@gmail.com>.
My bad, I created the patch when things looked fine with Eclipse. Note to
self: Make sure maven gives a green :)

Please take the modified patch -  ( cdi-interceptors-corrected.patch )

Thanks,
Vishwa

--
View this message in context: http://openejb.979440.n4.nabble.com/Patch-for-OPENEJB-1607-CDI-Interceptor-and-InterceptorBinding-examples-tp3628768p3656668.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: Patch for OPENEJB-1607 (CDI @Interceptor and @InterceptorBinding examples)

Posted by Karan Malhi <ka...@gmail.com>.
Hey Vishwa,

Can you confirm that you have the latest patch uploaded? Maven is not
able to compile the patch, if you can run mvn clean install
successfully, then let me know. I will then check if its an issue on
my end. Note that, sometimes IDE's will not issue a compile error but
maven will (thats what is happening in this case). We want to make
sure maven is happy :)

Thank you

On Fri, Jul 8, 2011 at 10:40 PM, David Blevins <da...@gmail.com> wrote:
> I've been incredibly busy with CDI integration.  Anyone have some spare bandwidth to review/commit this?
>
> Thanks again, Vishwa!  And thanks for the patience :)
>
> -David
>
> On Jun 28, 2011, at 2:27 PM, stratwine wrote:
>
>> Have deleted the old patch attachment and added a new one...
>> Pls review.. :)
>>
>> --
>> View this message in context: http://openejb.979440.n4.nabble.com/Patch-for-OPENEJB-1607-CDI-Interceptor-and-InterceptorBinding-examples-tp3628768p3631504.html
>> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>
>



-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi