You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "vikrantmehta123 (via GitHub)" <gi...@apache.org> on 2026/07/30 10:18:23 UTC
[PR] docs: Fixes incorrect type name in `UserDefinedLogicalNode` comment [datafusion]
vikrantmehta123 opened a new pull request, #23992:
URL: https://github.com/apache/datafusion/pull/23992
## Which issue does this PR close?
- N/A. This fixes a trivial doc comment. No issue filed.
## Rationale for this change
The doc comment in `datafusion/expr/src/logical_plan/extension.rs` incorrectly said it "derives UserDefinedLogicalNode to `UserDefinedLogicalNode` ( It named the same type twice ). This PR fixes this trivial documentation.
## What changes are included in this PR?
A single line containing the documentation fix, which corrects the source trait name from `UserDefinedLogicalNode` to `UserDefinedLogicalNodeCore`.
## Are these changes tested?
No tests needed as this is a comment-only change.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Fixes incorrect type name in `UserDefinedLogicalNode` comment [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway merged PR #23992:
URL: https://github.com/apache/datafusion/pull/23992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Fixes incorrect type name in `UserDefinedLogicalNode` comment [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23992:
URL: https://github.com/apache/datafusion/pull/23992#issuecomment-5130333003
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/23992?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 80.77%. Comparing base ([`2e3626e`](https://app.codecov.io/gh/apache/datafusion/commit/2e3626e72eb18f724d1501a5a98bbca24ea1257c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee8047c`](https://app.codecov.io/gh/apache/datafusion/commit/ee8047caea6e06620c0905ebe2afad8140601ec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #23992 +/- ##
==========================================
+ Coverage 80.75% 80.77% +0.01%
==========================================
Files 1096 1096
Lines 373588 373769 +181
Branches 373588 373769 +181
==========================================
+ Hits 301691 301894 +203
+ Misses 53896 53865 -31
- Partials 18001 18010 +9
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/23992?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org