You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/11 17:06:03 UTC
[PR] fix(mock): generate collision-safe certificate IDs [rocketmq-dashboard]
yyqdbngt opened a new pull request, #1934:
URL: https://github.com/apache/rocketmq-dashboard/pull/1934
## Summary
- prevent mock K8s certificate creations from sharing IDs in the same millisecond
- retain the timestamp in generated IDs and add a monotonic suffix
- cover same-clock creation and cleanup in the cluster service test
## Validation
- `NODE_OPTIONS=--no-experimental-webstorage npx vitest run src/services/clusterService.test.ts`
- targeted ESLint and repository formatting hooks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mock): generate collision-safe certificate IDs [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1934: fix(mock): generate collision-safe certificate IDs
URL: https://github.com/apache/rocketmq-dashboard/pull/1934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mock): generate collision-safe certificate IDs [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1934:
URL: https://github.com/apache/rocketmq-dashboard/pull/1934#issuecomment-5278764607
Closing after maintainer review: these mock-store tweaks (collision-safe IDs / strict deletions) only affect the development Mock mode and bring limited value relative to review and maintenance cost, so we are not taking them. Thanks for the effort — please focus future contributions on user-facing features and fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org