[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2871: [KYUUBI #2870] Fix sf0 query error in TPCH

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #2871:
URL: https://github.com/apache/incubator-kyuubi/pull/2871#discussion_r895527065


##########
extensions/spark/kyuubi-spark-connector-tpch/src/main/scala/org/apache/kyuubi/spark/connector/tpch/TPCHBatchScan.scala:
##########
@@ -94,7 +96,17 @@ class TPCHPartitionReader(
 
   private lazy val dateFmt: DateTimeFormatter = DateTimeFormatter.ofPattern("yyyy-MM-dd")
 
-  private val iterator = tpchTable.createGenerator(scale, index, parallelism).iterator
+  private val iterator = {
+    if (scale.equals(0.0) && !tpchTable.getTableName.equals("nation")

Review Comment:
   it's does not safe to use == or equals to compare double values



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org