[GitHub] [geode] bschuchardt opened pull request #3192: GEODE-6389 CI Failure: ConcurrentWANPropagation_1_DUnitTest.testRepli…

["bschuchardt (GitHub)" <gi...@apache.org>]

…catedSerialPropagation

I found a place where we were releasing pooled buffers twice.  The place
to release the buffer is in asyncClose but we were also doing it just
after calling that method in the run() method if the connection wasn't
thread-owned.  Both GEODE-6389 and GEODE-6377 were using
conserve-sockets=true so I think this is the source of the problem.

The GEODE-6389 failure, in particular, could only have come from
improper use of the buffer pool because it occured in a MessageStreamer
and they don't involve multithreaded use of a buffer.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3192 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt closed pull request #3192: GEODE-6389 CI Failure: ConcurrentWANPropagation_1_DUnitTest.testRepli…

["bschuchardt (GitHub)" <gi...@apache.org>]

[ pull request closed by bschuchardt ]

[ Full content available at: https://github.com/apache/geode/pull/3192 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org