You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/07/07 20:00:14 UTC
[jira] Created: (WINK-55) Source entity parameters should also be
supported according to spec
Source entity parameters should also be supported according to spec
-------------------------------------------------------------------
Key: WINK-55
URL: https://issues.apache.org/jira/browse/WINK-55
Project: Wink
Issue Type: Bug
Components: Common
Affects Versions: 0.1
Reporter: Bryant Luk
Plain "Source" parameters should be supported as a builtin provider. I don't think this messes up any of the other Source providers due to the isReadable doing ==.
{code}
@GET
public void getSource(Source someSource) {
}
{code}
I'll attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-55) Source entity parameters should also be
supported according to spec
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk resolved WINK-55.
----------------------------
Resolution: Fixed
Fix Version/s: 0.1
Assignee: Bryant Luk
Please re-open if this is still an issue.
> Source entity parameters should also be supported according to spec
> -------------------------------------------------------------------
>
> Key: WINK-55
> URL: https://issues.apache.org/jira/browse/WINK-55
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-55.patch
>
>
> Plain "Source" parameters should be supported as a builtin provider. I don't think this messes up any of the other Source providers due to the isReadable doing ==.
> {code}
> @GET
> public void getSource(Source someSource) {
> }
> {code}
> I'll attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-55) Source entity parameters should also be
supported according to spec
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728683#action_12728683 ]
Bryant Luk commented on WINK-55:
--------------------------------
Sounds good. The <StreamSource> will also need to be changed to <Source> I think but I can work that out and write a unit test today (and re-run the integration test).
> Source entity parameters should also be supported according to spec
> -------------------------------------------------------------------
>
> Key: WINK-55
> URL: https://issues.apache.org/jira/browse/WINK-55
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Attachments: WINK-55.patch
>
>
> Plain "Source" parameters should be supported as a builtin provider. I don't think this messes up any of the other Source providers due to the isReadable doing ==.
> {code}
> @GET
> public void getSource(Source someSource) {
> }
> {code}
> I'll attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-55) Source entity parameters should also be
supported according to spec
Posted by "Nadav Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728539#action_12728539 ]
Nadav Fischer commented on WINK-55:
-----------------------------------
I agree, and StreamSource sounds good.
But how about instead of adding a new PlainSourceProvider, add another condition to the StreamSourceProvider.isReadable, like so:
{code}
public boolean isReadable(Class<?> type, Type genericType, Annotation[] annotations, MediaType mediaType) {
return ((StreamSource.class == type || Source.class == type) && super.isReadable(mediaType));
}
{code}
What do you think?
> Source entity parameters should also be supported according to spec
> -------------------------------------------------------------------
>
> Key: WINK-55
> URL: https://issues.apache.org/jira/browse/WINK-55
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Attachments: WINK-55.patch
>
>
> Plain "Source" parameters should be supported as a builtin provider. I don't think this messes up any of the other Source providers due to the isReadable doing ==.
> {code}
> @GET
> public void getSource(Source someSource) {
> }
> {code}
> I'll attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-55) Source entity parameters should also be
supported according to spec
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-55.
--------------------------
> Source entity parameters should also be supported according to spec
> -------------------------------------------------------------------
>
> Key: WINK-55
> URL: https://issues.apache.org/jira/browse/WINK-55
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-55.patch
>
>
> Plain "Source" parameters should be supported as a builtin provider. I don't think this messes up any of the other Source providers due to the isReadable doing ==.
> {code}
> @GET
> public void getSource(Source someSource) {
> }
> {code}
> I'll attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-55) Source entity parameters should also be
supported according to spec
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728951#action_12728951 ]
Hudson commented on WINK-55:
----------------------------
Integrated in Wink-Trunk-JDK15 #14 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK15/14/])
Fix so Source can be a valid entity parameter
See []
> Source entity parameters should also be supported according to spec
> -------------------------------------------------------------------
>
> Key: WINK-55
> URL: https://issues.apache.org/jira/browse/WINK-55
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-55.patch
>
>
> Plain "Source" parameters should be supported as a builtin provider. I don't think this messes up any of the other Source providers due to the isReadable doing ==.
> {code}
> @GET
> public void getSource(Source someSource) {
> }
> {code}
> I'll attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-55) Source entity parameters should also be
supported according to spec
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk updated WINK-55:
---------------------------
Attachment: WINK-55.patch
I used a StreamSource. Maybe a different Source would be better?
> Source entity parameters should also be supported according to spec
> -------------------------------------------------------------------
>
> Key: WINK-55
> URL: https://issues.apache.org/jira/browse/WINK-55
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Attachments: WINK-55.patch
>
>
> Plain "Source" parameters should be supported as a builtin provider. I don't think this messes up any of the other Source providers due to the isReadable doing ==.
> {code}
> @GET
> public void getSource(Source someSource) {
> }
> {code}
> I'll attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.