You are viewing a plain text version of this content. The canonical link for it is here.
Posted to graffito-dev@incubator.apache.org by Ate Douma <at...@douma.nu> on 2005/11/24 22:40:31 UTC
Re: Upload file
Christophe Lombart wrote:
> Hi all,
>
> When uploading a file, ActionRequest.getContentType returns null
> instead of multipart/form-data. It was working with J2 M3. Is someone
> has similar issue with J2 head ?
Christophe, Greg and others,
I'm afraid I'm to blame for this :(
To get J2 JSR-168 TCK compliant, the HttpServletRequest for an invoked servlet from a portlet,
the getContentType() must return null: JST-168 requirement PLT.16.3.3 cxxxii
But, because Pluto simply delegates the ActionRequest.getContentType() to the underlying
HttpServletRequest it wraps (which is the concerning J2 ServletRequestImpl), this now always
returns null.
Which isn't correct of course, but seemingly not tested by the TCK... J2 currently passes the TCK.
Sorry for this and other similar problems with the same cause.
I'm going to devise a different solution still TCK compliant and restore these broken features.
I already have thought out one possible solution but it'll take me some time to implement and
test again. But you can be assured I'll have this fixed before our J2 2.0-FINAL release (which
is planned within 2 weeks!).
As I don't have a FileUpload testcase currently available, it would be great you could test
this for me once I've committed my solution for this. I'll notify the graffito list when I do.
Regards, Ate
>
>
> Thanks,
> Christophe
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
>
>
Re: Upload file
Posted by Ate Douma <at...@douma.nu>.
Fix implemented and already tested against the tck ;-)
Christophe, could you please test if FileUpload now is working again?
Regards,
Ate
Ate Douma wrote:
> Christophe Lombart wrote:
>> Hi all,
>>
>> When uploading a file, ActionRequest.getContentType returns null
>> instead of multipart/form-data. It was working with J2 M3. Is someone
>> has similar issue with J2 head ?
>
> Christophe, Greg and others,
>
> I'm afraid I'm to blame for this :(
>
> To get J2 JSR-168 TCK compliant, the HttpServletRequest for an invoked
> servlet from a portlet,
> the getContentType() must return null: JST-168 requirement PLT.16.3.3
> cxxxii
> But, because Pluto simply delegates the ActionRequest.getContentType()
> to the underlying
> HttpServletRequest it wraps (which is the concerning J2
> ServletRequestImpl), this now always
> returns null.
> Which isn't correct of course, but seemingly not tested by the TCK... J2
> currently passes the TCK.
> Sorry for this and other similar problems with the same cause.
>
> I'm going to devise a different solution still TCK compliant and restore
> these broken features.
> I already have thought out one possible solution but it'll take me some
> time to implement and
> test again. But you can be assured I'll have this fixed before our J2
> 2.0-FINAL release (which
> is planned within 2 weeks!).
>
> As I don't have a FileUpload testcase currently available, it would be
> great you could test
> this for me once I've committed my solution for this. I'll notify the
> graffito list when I do.
>
> Regards, Ate
>
>>
>>
>> Thanks,
>> Christophe
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
>> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>>
>>
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: Upload file
Posted by Ate Douma <at...@douma.nu>.
Fix implemented and already tested against the tck ;-)
Christophe, could you please test if FileUpload now is working again?
Regards,
Ate
Ate Douma wrote:
> Christophe Lombart wrote:
>> Hi all,
>>
>> When uploading a file, ActionRequest.getContentType returns null
>> instead of multipart/form-data. It was working with J2 M3. Is someone
>> has similar issue with J2 head ?
>
> Christophe, Greg and others,
>
> I'm afraid I'm to blame for this :(
>
> To get J2 JSR-168 TCK compliant, the HttpServletRequest for an invoked
> servlet from a portlet,
> the getContentType() must return null: JST-168 requirement PLT.16.3.3
> cxxxii
> But, because Pluto simply delegates the ActionRequest.getContentType()
> to the underlying
> HttpServletRequest it wraps (which is the concerning J2
> ServletRequestImpl), this now always
> returns null.
> Which isn't correct of course, but seemingly not tested by the TCK... J2
> currently passes the TCK.
> Sorry for this and other similar problems with the same cause.
>
> I'm going to devise a different solution still TCK compliant and restore
> these broken features.
> I already have thought out one possible solution but it'll take me some
> time to implement and
> test again. But you can be assured I'll have this fixed before our J2
> 2.0-FINAL release (which
> is planned within 2 weeks!).
>
> As I don't have a FileUpload testcase currently available, it would be
> great you could test
> this for me once I've committed my solution for this. I'll notify the
> graffito list when I do.
>
> Regards, Ate
>
>>
>>
>> Thanks,
>> Christophe
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
>> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>>
>>
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
>
>