[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3959: fix Volume migration across pools sometimes loses volume

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3959: fix Volume migration across pools sometimes loses volume
URL: https://github.com/apache/cloudstack/pull/3959#discussion_r390407552
 
 

 ##########
 File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
 ##########
 @@ -486,6 +486,9 @@ public void copyAsync(DataObject srcData, DataObject destData, Host destHost, As
             if (answer != null && !answer.getResult()) {
                 errMsg = answer.getDetails();
             }
+            if (answer == null) {
+                errMsg = "answer is null, set to error for CopyCommandResult";
 
 Review comment:
   I don't understand this error message. Can you make it very clear, please?
   for example "no answer from came back from copyCommand, considering it as failed."
   preferably even with some data like src, dest, src.type and dest.type

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services