You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/04 04:52:20 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #634: build: Remove the redundant check from Applicaiton.mk
xiaoxiang781216 opened a new pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634
## Summary
It's better to report error if user forget set PRIORITY or STACKSIZE
## Impact
Build sytem
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d edited a comment on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
v01d edited a comment on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-810439190
I imagine not setting these variables probably returns in some weird error right? Have you tried?
Maybe an error message could be printed in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-810474335
Here is the error reported by gcc:
```
builtin_list.h:2:12: error: expected expression before ‘,’ token
2 | { "hello", , , hello_main },
```
If user open builtin_list.h, he will find the reason easily:
```
{ "sh", 100, 65536, sh_main },
{ "hello", , , hello_main },
{ "nsh", 100, 65536, nsh_main },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-810439190
I imagine not settings this variables probably returns in some weird error right? Have you tried?
Maybe an error message could be printed in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813051900
What was the purpose of all those `register::` anyway? I think only one, unconditional, `register::` would have worked the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813036105
Sorry I missed this one.
I think it would be good to explicitly print a message stating the missing definitions. But I guess it is not critical as it would be uncommon to have these variables missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813893076
I'm not sure if @v01d have any concerns. I'll merge this one, please ping if there is anything to look at.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813035851
@v01d do you think the error message acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813055215
> We need one empty register to handle no program(library only) case.
Yes, this is what I meant. Only one empty register would've worked the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813853945
@Ouss4 @v01d could you merge this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813054789
We need one empty register to handle no program(library only) case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #634: build: Remove the redundant check from Applicaiton.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634#issuecomment-813052000
> What was the purpose of all those `register::` anyway? I think only one, unconditional, `register::` would have worked the same way.
I mean + one, besides the first `register::` that does all the work...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org