You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/24 03:38:16 UTC

[GitHub] [spark] srowen commented on pull request #32991: [SPARK-35678][ML][FOLLOWUP] softmax support offset and step

srowen commented on pull request #32991:
URL: https://github.com/apache/spark/pull/32991#issuecomment-867309689


   I would revert the ANN change - something's too dependent on the math and ordering of operations or something. If we can just revert that and see it work in a follow up PR, that's a way forward; this may not even fail every time in master as I think it's simply flaky ATM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org