You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/16 19:07:00 UTC
[jira] [Updated] (STORM-2483) wrong parameters order
[ https://issues.apache.org/jira/browse/STORM-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated STORM-2483:
----------------------------------
Labels: pull-request-available (was: )
> wrong parameters order
> ----------------------
>
> Key: STORM-2483
> URL: https://issues.apache.org/jira/browse/STORM-2483
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.3
> Environment: storm-core:1.0.3
> Reporter: Jacob Liu
> Priority: Major
> Labels: pull-request-available
>
> org.apache.storm.utils.Utils#getGlobalStreamId has wrong parameters order:
>
> public static GlobalStreamId getGlobalStreamId(String streamId, String componentId) {
> if (componentId == null) {
> return new GlobalStreamId(streamId, DEFAULT_STREAM_ID);
> }
> return new GlobalStreamId(streamId, componentId);
> }
> but GlobalStreamId constructor is: public GlobalStreamId(
> String componentId,
> String streamId)
> so i think the nice code is:
> public static GlobalStreamId getGlobalStreamId(String streamId, String componentId) {
> if (streamId == null) {
> return new GlobalStreamId(componentId, DEFAULT_STREAM_ID);
> }
> return new GlobalStreamId(componentId, streamId);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)