You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Claus Ibsen <cl...@gmail.com> on 2008/12/10 09:17:58 UTC
Re: svn commit: r724806 - in /activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel: component/rss/RssFilterTest.java dataformat/rss/RssFilterWithXPathTest.java
Hi Jon
Can you not specify the expected body type directly in your filter
bean instead of ugly type casts?
public boolean titleContainsCamel(@Body Object body) {
> + SyndEntry firstEntry = (SyndEntry) ((SyndFeed) body).getEntries().get(0);
So it could be like this:
public boolean titleContainsCamel(@Body SyncFeed feed) {
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Tue, Dec 9, 2008 at 7:27 PM, <ja...@apache.org> wrote:
> Author: janstey
> Date: Tue Dec 9 10:27:03 2008
> New Revision: 724806
>
> URL: http://svn.apache.org/viewvc?rev=724806&view=rev
> Log:
> CAMEL-1172 - Add example of how to filter rss entries.
>
> Added:
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java (with props)
> Modified:
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java
>
> Added: activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java?rev=724806&view=auto
> ==============================================================================
> --- activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java (added)
> +++ activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java Tue Dec 9 10:27:03 2008
> @@ -0,0 +1,70 @@
> +/**
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements. See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.apache.camel.component.rss;
> +
> +import java.util.Iterator;
> +
> +import javax.naming.Context;
> +
> +import com.sun.syndication.feed.synd.SyndEntry;
> +import com.sun.syndication.feed.synd.SyndFeed;
> +
> +import org.apache.camel.Body;
> +import org.apache.camel.ContextTestSupport;
> +import org.apache.camel.builder.RouteBuilder;
> +import org.apache.camel.component.mock.MockEndpoint;
> +import org.apache.camel.util.jndi.JndiContext;
> +
> +public class RssFilterTest extends ContextTestSupport {
> +
> + public void testFilterOutNonCamelPosts() throws Exception {
> + MockEndpoint mock = getMockEndpoint("mock:result");
> + mock.expectedMessageCount(6);
> + mock.assertIsSatisfied();
> + }
> +
> + @Override
> + protected Context createJndiContext() throws Exception {
> + JndiContext jndi = new JndiContext();
> + jndi.bind("myFilterBean", new FilterBean());
> + return jndi;
> + }
> +
> + protected RouteBuilder createRouteBuilder() throws Exception {
> + return new RouteBuilder() {
> + public void configure() throws Exception {
> + // See RssFilterWithXPathTest for an example of how to do this with XPath
> +
> + // START SNIPPET: ex1
> + // only entries with Camel in the title will get through the
> + // filter
> + from("rss:file:src/test/data/rss20.xml?splitEntries=true&consumer.delay=100").
> + filter().method("myFilterBean", "titleContainsCamel").to("mock:result");
> + // END SNIPPET: ex1
> + }
> + };
> + }
> +
> + // START SNIPPET: ex2
> + public static class FilterBean {
> + public boolean titleContainsCamel(@Body Object body) {
> + SyndEntry firstEntry = (SyndEntry) ((SyndFeed) body).getEntries().get(0);
> + return firstEntry.getTitle().contains("Camel");
> + }
> + }
> + // END SNIPPET: ex2
> +}
>
> Propchange: activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java
> ------------------------------------------------------------------------------
> svn:eol-style = native
>
> Modified: activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java?rev=724806&r1=724805&r2=724806&view=diff
> ==============================================================================
> --- activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java (original)
> +++ activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java Tue Dec 9 10:27:03 2008
> @@ -16,33 +16,19 @@
> */
> package org.apache.camel.dataformat.rss;
>
> -import java.util.List;
> -
> -import com.sun.syndication.feed.synd.SyndFeed;
> -
> -import org.apache.camel.ContextTestSupport;
> -import org.apache.camel.Exchange;
> -import org.apache.camel.Message;
> import org.apache.camel.builder.RouteBuilder;
> -import org.apache.camel.component.mock.MockEndpoint;
> -import org.apache.camel.component.rss.RssEndpoint;
> -import org.apache.camel.component.rss.RssUtils;
> +import org.apache.camel.component.rss.RssFilterTest;
>
> -public class RssFilterWithXPathTest extends ContextTestSupport {
> +public class RssFilterWithXPathTest extends RssFilterTest {
>
> - public void testMarshalToXmlThenFilter() throws Exception {
> - MockEndpoint mock = getMockEndpoint("mock:result");
> - mock.expectedMessageCount(6);
> - mock.assertIsSatisfied();
> - }
> -
> protected RouteBuilder createRouteBuilder() throws Exception {
> return new RouteBuilder() {
> public void configure() throws Exception {
> - // START SNIPPET: ex
> - // only entries with Camel in the title will get through the filter
> - from("rss:file:src/test/data/rss20.xml?splitEntries=true&consumer.delay=100").marshal().rss().
> - filter().xpath("//item/title[contains(.,'Camel')]").to("mock:result");
> + // START SNIPPET: ex
> + // only entries with Camel in the title will get through the
> + // filter
> + from("rss:file:src/test/data/rss20.xml?splitEntries=true&consumer.delay=100")
> + .marshal().rss().filter().xpath("//item/title[contains(.,'Camel')]").to("mock:result");
> // END SNIPPET: ex
> }
> };
>
>
>
Re: svn commit: r724806 - in /activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel: component/rss/RssFilterTest.java dataformat/rss/RssFilterWithXPathTest.java
Posted by Jon Anstey <ja...@gmail.com>.
Apparently you can! Sweet. That is much nicer. I'll commit a fix for this
now.
On Wed, Dec 10, 2008 at 4:47 AM, Claus Ibsen <cl...@gmail.com> wrote:
> Hi Jon
>
> Can you not specify the expected body type directly in your filter
> bean instead of ugly type casts?
> public boolean titleContainsCamel(@Body Object body) {
> > + SyndEntry firstEntry = (SyndEntry) ((SyndFeed)
> body).getEntries().get(0);
>
> So it could be like this:
> public boolean titleContainsCamel(@Body SyncFeed feed) {
>
>
>
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>
>
>
> On Tue, Dec 9, 2008 at 7:27 PM, <ja...@apache.org> wrote:
> > Author: janstey
> > Date: Tue Dec 9 10:27:03 2008
> > New Revision: 724806
> >
> > URL: http://svn.apache.org/viewvc?rev=724806&view=rev
> > Log:
> > CAMEL-1172 - Add example of how to filter rss entries.
> >
> > Added:
> >
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java
> (with props)
> > Modified:
> >
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java
> >
> > Added:
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java
> > URL:
> http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java?rev=724806&view=auto
> >
> ==============================================================================
> > ---
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java
> (added)
> > +++
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java
> Tue Dec 9 10:27:03 2008
> > @@ -0,0 +1,70 @@
> > +/**
> > + * Licensed to the Apache Software Foundation (ASF) under one or more
> > + * contributor license agreements. See the NOTICE file distributed with
> > + * this work for additional information regarding copyright ownership.
> > + * The ASF licenses this file to You under the Apache License, Version
> 2.0
> > + * (the "License"); you may not use this file except in compliance with
> > + * the License. You may obtain a copy of the License at
> > + *
> > + * http://www.apache.org/licenses/LICENSE-2.0
> > + *
> > + * Unless required by applicable law or agreed to in writing, software
> > + * distributed under the License is distributed on an "AS IS" BASIS,
> > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> > + * See the License for the specific language governing permissions and
> > + * limitations under the License.
> > + */
> > +package org.apache.camel.component.rss;
> > +
> > +import java.util.Iterator;
> > +
> > +import javax.naming.Context;
> > +
> > +import com.sun.syndication.feed.synd.SyndEntry;
> > +import com.sun.syndication.feed.synd.SyndFeed;
> > +
> > +import org.apache.camel.Body;
> > +import org.apache.camel.ContextTestSupport;
> > +import org.apache.camel.builder.RouteBuilder;
> > +import org.apache.camel.component.mock.MockEndpoint;
> > +import org.apache.camel.util.jndi.JndiContext;
> > +
> > +public class RssFilterTest extends ContextTestSupport {
> > +
> > + public void testFilterOutNonCamelPosts() throws Exception {
> > + MockEndpoint mock = getMockEndpoint("mock:result");
> > + mock.expectedMessageCount(6);
> > + mock.assertIsSatisfied();
> > + }
> > +
> > + @Override
> > + protected Context createJndiContext() throws Exception {
> > + JndiContext jndi = new JndiContext();
> > + jndi.bind("myFilterBean", new FilterBean());
> > + return jndi;
> > + }
> > +
> > + protected RouteBuilder createRouteBuilder() throws Exception {
> > + return new RouteBuilder() {
> > + public void configure() throws Exception {
> > + // See RssFilterWithXPathTest for an example of how to
> do this with XPath
> > +
> > + // START SNIPPET: ex1
> > + // only entries with Camel in the title will get through
> the
> > + // filter
> > +
> from("rss:file:src/test/data/rss20.xml?splitEntries=true&consumer.delay=100").
> > + filter().method("myFilterBean",
> "titleContainsCamel").to("mock:result");
> > + // END SNIPPET: ex1
> > + }
> > + };
> > + }
> > +
> > + // START SNIPPET: ex2
> > + public static class FilterBean {
> > + public boolean titleContainsCamel(@Body Object body) {
> > + SyndEntry firstEntry = (SyndEntry) ((SyndFeed)
> body).getEntries().get(0);
> > + return firstEntry.getTitle().contains("Camel");
> > + }
> > + }
> > + // END SNIPPET: ex2
> > +}
> >
> > Propchange:
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/component/rss/RssFilterTest.java
> >
> ------------------------------------------------------------------------------
> > svn:eol-style = native
> >
> > Modified:
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java
> > URL:
> http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java?rev=724806&r1=724805&r2=724806&view=diff
> >
> ==============================================================================
> > ---
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java
> (original)
> > +++
> activemq/camel/trunk/components/camel-rss/src/test/java/org/apache/camel/dataformat/rss/RssFilterWithXPathTest.java
> Tue Dec 9 10:27:03 2008
> > @@ -16,33 +16,19 @@
> > */
> > package org.apache.camel.dataformat.rss;
> >
> > -import java.util.List;
> > -
> > -import com.sun.syndication.feed.synd.SyndFeed;
> > -
> > -import org.apache.camel.ContextTestSupport;
> > -import org.apache.camel.Exchange;
> > -import org.apache.camel.Message;
> > import org.apache.camel.builder.RouteBuilder;
> > -import org.apache.camel.component.mock.MockEndpoint;
> > -import org.apache.camel.component.rss.RssEndpoint;
> > -import org.apache.camel.component.rss.RssUtils;
> > +import org.apache.camel.component.rss.RssFilterTest;
> >
> > -public class RssFilterWithXPathTest extends ContextTestSupport {
> > +public class RssFilterWithXPathTest extends RssFilterTest {
> >
> > - public void testMarshalToXmlThenFilter() throws Exception {
> > - MockEndpoint mock = getMockEndpoint("mock:result");
> > - mock.expectedMessageCount(6);
> > - mock.assertIsSatisfied();
> > - }
> > -
> > protected RouteBuilder createRouteBuilder() throws Exception {
> > return new RouteBuilder() {
> > public void configure() throws Exception {
> > - // START SNIPPET: ex
> > - // only entries with Camel in the title will get through
> the filter
> > -
> from("rss:file:src/test/data/rss20.xml?splitEntries=true&consumer.delay=100").marshal().rss().
> > -
> filter().xpath("//item/title[contains(.,'Camel')]").to("mock:result");
> > + // START SNIPPET: ex
> > + // only entries with Camel in the title will get through
> the
> > + // filter
> > +
> from("rss:file:src/test/data/rss20.xml?splitEntries=true&consumer.delay=100")
> > +
> .marshal().rss().filter().xpath("//item/title[contains(.,'Camel')]").to("mock:result");
> > // END SNIPPET: ex
> > }
> > };
> >
> >
> >
>
--
Cheers,
Jon
http://janstey.blogspot.com/