You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by ve...@apache.org on 2009/07/05 22:47:47 UTC

svn commit: r791320 - /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/ds/OMDataSourceExtBase.java

Author: veithen
Date: Sun Jul  5 20:47:47 2009
New Revision: 791320

URL: http://svn.apache.org/viewvc?rev=791320&view=rev
Log:
Added review comment.

Modified:
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/ds/OMDataSourceExtBase.java

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/ds/OMDataSourceExtBase.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/ds/OMDataSourceExtBase.java?rev=791320&r1=791319&r2=791320&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/ds/OMDataSourceExtBase.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/ds/OMDataSourceExtBase.java Sun Jul  5 20:47:47 2009
@@ -148,6 +148,7 @@
             OMDocument omDocument = builder.getDocument();
             Iterator it = omDocument.getChildren();
             while (it.hasNext()) {
+                // TODO: this is extremely inefficient since next() will actually build the node!
                 OMNode omNode = (OMNode) it.next();
                 omNode.serializeAndConsume(writer);
             }