You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2019/07/24 14:24:26 UTC
[GitHub] [incubator-doris] imay commented on a change in pull request #1544:
Fix bug that getting compatible type for TIME with other types fails
imay commented on a change in pull request #1544: Fix bug that getting compatible type for TIME with other types fails
URL: https://github.com/apache/incubator-doris/pull/1544#discussion_r306838777
##########
File path: fe/src/main/java/org/apache/doris/catalog/Type.java
##########
@@ -822,29 +828,38 @@ public Integer getNumPrecRadix() {
compatibilityMatrix[FLOAT.ordinal()][DOUBLE.ordinal()] = PrimitiveType.DOUBLE;
compatibilityMatrix[FLOAT.ordinal()][DATE.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[FLOAT.ordinal()][DATETIME.ordinal()] = PrimitiveType.INVALID_TYPE;
+ compatibilityMatrix[FLOAT.ordinal()][TIME.ordinal()] = PrimitiveType.TIME;
compatibilityMatrix[FLOAT.ordinal()][VARCHAR.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[FLOAT.ordinal()][CHAR.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[FLOAT.ordinal()][HLL.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DOUBLE.ordinal()][DATE.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DOUBLE.ordinal()][DATETIME.ordinal()] =
PrimitiveType.INVALID_TYPE;
+ compatibilityMatrix[DOUBLE.ordinal()][TIME.ordinal()] = PrimitiveType.TIME;
compatibilityMatrix[DOUBLE.ordinal()][VARCHAR.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DOUBLE.ordinal()][CHAR.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DOUBLE.ordinal()][HLL.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DATE.ordinal()][DATETIME.ordinal()] = PrimitiveType.DATETIME;
+ compatibilityMatrix[DATE.ordinal()][TIME.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DATE.ordinal()][VARCHAR.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DATE.ordinal()][CHAR.ordinal()] = PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DATE.ordinal()][HLL.ordinal()] = PrimitiveType.INVALID_TYPE;
+ compatibilityMatrix[DATETIME.ordinal()][TIME.ordinal()] =
+ PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DATETIME.ordinal()][VARCHAR.ordinal()] =
PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DATETIME.ordinal()][CHAR.ordinal()] =
PrimitiveType.INVALID_TYPE;
compatibilityMatrix[DATETIME.ordinal()][HLL.ordinal()] =
PrimitiveType.INVALID_TYPE;
+ compatibilityMatrix[TIME.ordinal()][VARCHAR.ordinal()] = PrimitiveType.VARCHAR;
+ compatibilityMatrix[TIME.ordinal()][CHAR.ordinal()] = PrimitiveType.VARCHAR;
+ compatibilityMatrix[TIME.ordinal()][HLL.ordinal()] = PrimitiveType.INVALID_TYPE;
Review comment:
TIME.ordinal is bigger than HLL CHAR and VARCHAR, So I think there is some problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org