You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/06/22 23:35:39 UTC
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17626
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
[thirdparty] fix building crcutil with GCC 10
This patch fixes building crcutil with GCC 10. Prior to this patch,
version comparision didn't work properly for two-digits versions,
so -msse2 and -mcrc32 flags would not be added when building with
GCC 10.
Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/crcutil-autogen.patch
2 files changed, 35 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/17626/1
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Jul 2021 23:09:25 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 1:
The change looks good to me. I don't have a strong opinion on the ordering of patching.
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 25 Jun 2021 20:54:51 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 1:
> The change looks good to me. I don't have a strong opinion on the
> ordering of patching.
Thank you for the review! I already posted a pull request for the crcutil repo athttps://github.com/cloudera/crcutil/pull/4
I hope to get that merged, and then I'll need to update this patch to use the newer snapshot of the crcutil package.
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 26 Jun 2021 00:10:43 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17626/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17626/1//COMMIT_MSG@9
PS1, Line 9: This patch fixes building crcutil with GCC 10. Prior to this patch,
> Yep, I also was looking at that, but so far I saw everything there is done
Opened a pull request: https://github.com/cloudera/crcutil/pull/4
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Jun 2021 07:03:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17626
to look at the new patch set (#2).
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
[thirdparty] fix building crcutil with GCC 10
This patch updates the version of crcutil used in Kudu's thirdparty.
With this patch, it's now possible to build crcutil with GCC 10. Prior
to this patch, version comparision didn't work properly for two-digits
versions, so -msse2 and -mcrc32 flags would not be added when building
with GCC 10.
Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/17626/2
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 2:
> LGTM. I don't quite understand the rebalancing test failure, but it
> doesn't look related.
The rebalancing test failed due to SIGSEGV from within libtcmalloc. Most likely reason cited to be double-free or other application programming error related to concurrent freeing the same entity: https://github.com/gperftools/gperftools/issues/125
However, the stack trace doesn't provides any hints on what exact memory might be twice-deallocated, i.e. I don't see an exact place pointed at. The stack hints on something created during static initialization phase, I guess:
PC: @ 0x7f59b21cddfb tcmalloc::ThreadCache::ReleaseToCentralCache()
*** SIGSEGV (@0x10000555ae1) received by PID 3837 (TID 0x7f59ab2838c0) from PID 5593825; stack trace: ***
@ 0x7f59b2d26980 (unknown)
@ 0x7f59b21cddfb tcmalloc::ThreadCache::ReleaseToCentralCache()
@ 0x7f59b21ce185 tcmalloc::ThreadCache::ListTooLong()
@ 0x555ae00fe3ed std::unordered_map<>::~unordered_map()
@ 0x7f59b0aec161 (unknown)
@ 0x7f59b0aec25a exit
@ 0x7f59b0acabfe __libc_start_main
@ 0x555ae0055e4a _start
I'm not going to dig any further, but clearly this failure isn't related to this patch.
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Jul 2021 23:09:16 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 25 Jun 2021 20:54:56 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
[thirdparty] fix building crcutil with GCC 10
This patch updates the version of crcutil used in Kudu's thirdparty.
With this patch, it's now possible to build crcutil with GCC 10. Prior
to this patch, version comparision didn't work properly for two-digits
versions, so -msse2 and -mcrc32 flags would not be added when building
with GCC 10.
Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Reviewed-on: http://gerrit.cloudera.org:8080/17626
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17626/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17626/1//COMMIT_MSG@9
PS1, Line 9: This patch fixes building crcutil with GCC 10. Prior to this patch,
> Is it possible to land this change in the http://github.com/cloudera/crcuti
Yep, I also was looking at that, but so far I saw everything there is done in a different order: first things appear as patches somewhere, and then those goes into crcutil. I guess this time we might do it in a different order, yep.
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jun 2021 20:45:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 2: Code-Review+2
LGTM. I don't quite understand the rebalancing test failure, but it doesn't look related.
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Jul 2021 22:49:59 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix building crcutil with GCC 10
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 )
Change subject: [thirdparty] fix building crcutil with GCC 10
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17626/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17626/1//COMMIT_MSG@9
PS1, Line 9: This patch fixes building crcutil with GCC 10. Prior to this patch,
Is it possible to land this change in the http://github.com/cloudera/crcutil repo and then update the hash in vars.sh instead of patching it in the Kudu build?
--
To view, visit http://gerrit.cloudera.org:8080/17626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaba794ce00eb64a29e8038a8a2f4883f35c975a
Gerrit-Change-Number: 17626
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jun 2021 02:14:05 +0000
Gerrit-HasComments: Yes