You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/14 00:55:53 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #9140: [dashboard] remove loading spinner in missing chart holder

codecov-io commented on issue #9140: [dashboard] remove loading spinner in missing chart holder
URL: https://github.com/apache/incubator-superset/pull/9140#issuecomment-586045588
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9140?src=pr&el=h1) Report
   > Merging [#9140](https://codecov.io/gh/apache/incubator-superset/pull/9140?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/966d321703480c5edbccdd17e1b09cd9969e0264?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9140/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9140?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9140      +/-   ##
   ==========================================
   - Coverage    59.1%   59.06%   -0.04%     
   ==========================================
     Files         372      372              
     Lines       11922    11922              
     Branches     2919     2919              
   ==========================================
   - Hits         7046     7042       -4     
   - Misses       4694     4698       +4     
     Partials      182      182
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9140?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9140/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL01pc3NpbmdDaGFydC5qc3g=) | `100% <ø> (ø)` | :arrow_up: |
   | [superset-frontend/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9140/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy5qc3g=) | `55.55% <0%> (-44.45%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9140?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9140?src=pr&el=footer). Last update [966d321...6cbb296](https://codecov.io/gh/apache/incubator-superset/pull/9140?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org