You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/08 21:32:17 UTC

Review Request 54545: Cleaned up expectations in api_tests.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54545/
-----------------------------------------------------------

Review request for mesos and Anand Mazumdar.


Repository: mesos


Description
-------

Changed `EXPECT_EQ` to `ASSERRT_EQ` for cases where assertion is more
appropriate.


Diffs
-----

  src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61 

Diff: https://reviews.apache.org/r/54545/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 54545: Cleaned up expectations in api_tests.cpp.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54545/
-----------------------------------------------------------

(Updated Dec. 12, 2016, 12:32 a.m.)


Review request for mesos and Anand Mazumdar.


Changes
-------

rebased. NNFR.


Repository: mesos


Description
-------

Changed `EXPECT_EQ` to `ASSERRT_EQ` for cases where assertion is more
appropriate.


Diffs (updated)
-----

  src/tests/api_tests.cpp 098804881c34acf53a43e332caa677c288bf8b06 

Diff: https://reviews.apache.org/r/54545/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 54545: Cleaned up expectations in api_tests.cpp.

Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54545/#review158767
-----------------------------------------------------------


Ship it!




Thanks for the cleanup!

- Anand Mazumdar


On Dec. 8, 2016, 9:32 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54545/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed `EXPECT_EQ` to `ASSERRT_EQ` for cases where assertion is more
> appropriate.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61 
> 
> Diff: https://reviews.apache.org/r/54545/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>