You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Eric Pugh (Jira)" <ji...@apache.org> on 2023/01/31 15:21:00 UTC

[jira] [Commented] (SOLR-16640) Admin UI SQL page should be hidden if plugin is not enabled

    [ https://issues.apache.org/jira/browse/SOLR-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682607#comment-17682607 ] 

Eric Pugh commented on SOLR-16640:
----------------------------------

That is really ugly...    I think part of the downside of modularization is that we broke some assumptions!

> Admin UI SQL page should be hidden if plugin is not enabled
> -----------------------------------------------------------
>
>                 Key: SOLR-16640
>                 URL: https://issues.apache.org/jira/browse/SOLR-16640
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Admin UI
>            Reporter: Alex Deparvu
>            Priority: Minor
>
> SQL page is available even if plugin is not enabled (it is disabled by default).
> Also, page errors out if you run any sql, but will not properly display some error message, the js will break on parsing the exception coming in the response.
> Slack discussion https://the-asf.slack.com/archives/CEKUCUNE9/p1674843671145009
> Error response from backend if plugin is not enabled
> {noformat}
> {
>   "error":{
>     "metadata":[
>       "error-class","org.apache.solr.common.SolrException",
>       "root-error-class","java.lang.ClassNotFoundException"],
>     "msg":" Error loading class 'solr.SQLHandler'",
>     "trace":"org.apache.solr.common.SolrException:  Error loading class 'solr.SQLHandler'\n\tat org.apache.solr.core.SolrResourceLoader.findClass(SolrResourceLoader.java:548)\n\tat org.apache.solr.core.SolrResourceLoader.findClass(SolrResourceLoader.java:469)\n\tat org.apache.solr.core.SolrCore.createInstance(SolrCore.java:933)\n\tat org.apache.solr.core.PluginBag$LazyPluginHolder.createInst(PluginBag.java:502)\n\tat org.apache.solr.core.PluginBag$LazyPluginHolder.get(PluginBag.java:484)\n\tat org.apache.solr.core.PluginBag.get(PluginBag.java:185)\n\tat org.apache.solr.handler.RequestHandlerBase.getRequestHandler(RequestHandlerBase.java:312)\n\tat org.apache.solr.core.SolrCore.getRequestHandler(SolrCore.java:1955)\n\tat org.apache.solr.servlet.HttpSolrCall.extractHandlerFromURLPath(HttpSolrCall.java:430)\n\tat org.apache.solr.servlet.HttpSolrCall.init(HttpSolrCall.java:326)\n\tat org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:510)\n\tat org.apache.solr.servlet.SolrDispatchFilter.dispatch(SolrDispatchFilter.java:252)\n\tat org.apache.solr.servlet.SolrDispatchFilter.lambda$doFilter$0(SolrDispatchFilter.java:220)\n\tat org.apache.solr.servlet.ServletUtils.traceHttpRequestExecution2(ServletUtils.java:257)\n\tat org.apache.solr.servlet.ServletUtils.rateLimitRequest(ServletUtils.java:227)\n\tat org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:215)\n\tat org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:197)\n ... Caused by: java.lang.ClassNotFoundException: solr.SQLHandler\n\tat java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)\n\tat java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)\n\tat java.base/java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:872)\n\tat java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)\n\tat java.base/java.lang.Class.forName0(Native Method)\n\tat java.base/java.lang.Class.forName(Class.java:467)\n\tat org.apache.solr.core.SolrResourceLoader.findClass(SolrResourceLoader.java:532)\n\t... 56 more\n",
>     "code":500}}
> {noformat}
> Js breaking due to error response instead of regular response
> {noformat}
> angular.min.js?_=9.1.0:146 TypeError: Cannot read properties of undefined (reading 'docs')
>     at sqlquery.js?_=9.1.0:63:49
>     at I (angular-resource.min.js?_=9.1.0:31:74)
>     at angular.min.js?_=9.1.0:159:235
>     at m.$digest (angular.min.js?_=9.1.0:170:385)
>     at m.$apply (angular.min.js?_=9.1.0:174:259)
>     at k (angular.min.js?_=9.1.0:125:309)
>     at v (angular.min.js?_=9.1.0:130:422)
>     at y.onload (angular.min.js?_=9.1.0:131:335) 'Possibly unhandled rejection: {}'
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org