You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2021/07/23 05:10:00 UTC
[jira] [Comment Edited] (HBASE-25938) The
SnapshotOfRegionAssignmentFromMeta.initialize call in
FavoredNodeLoadBalancer is just a dummy one
[ https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385941#comment-17385941 ]
Michael Stack edited comment on HBASE-25938 at 7/23/21, 5:09 AM:
-----------------------------------------------------------------
This change was reverted from branch-2.3. Removing 2.3.6 as a fix version.
{code:java}
commit 075c055c871ec0b7271114fc24e24d7eb92180cc
Author: stack <st...@apache.org>
Date: Tue Jun 1 15:35:12 2021 -0700 Revert "HBASE-25938 The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one (#3329)" This reverts commit 0620f08bdf4a28ff8e80db31d1e655b8abca7fbb.
Mistakenly pushed on branch-2.3
{code}
was (Author: stack):
This change was reverted from branch-2.3. Removing 2.3.6 as a fix version.
{code:java}
075c055c87 Revert "HBASE-25938 The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one (#3329)"{code}
> The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-25938
> URL: https://issues.apache.org/jira/browse/HBASE-25938
> Project: HBase
> Issue Type: Bug
> Components: Balancer, FavoredNodes
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.4
>
>
> After we introduced FavoredNodesManager, we do not need to load this information every time when balancing, as all the updates to favored nodes will go to FavoredNodesManager and it can update its in memory state accordingly.
> The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one in FavoredNodeLoadBalancer, as we never use it in the method.
> It will introduce a full scan on hbase:meta so let's just remove it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)