You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by YangYongZheng <34...@qq.com> on 2018/09/13 02:13:25 UTC
答复: [Discuss]Java Chassis Support Spring Boot 2.0
Right~, that's better way, but need more works
Best Regards!
YangYongZheng
-----邮件原件-----
发件人: Yang Bo [mailto:oakyang@gmail.com]
发送时间: 2018年9月13日 10:02
收件人: dev@servicecomb.apache.org
主题: Re: [Discuss]Java Chassis Support Spring Boot 2.0
Hi,
It seems to me that just changing the spring/springboot version is not enough. There might be inconsistent implementation details which will require code change between spring 4.x and spring 5.x.
It's better that we remove spring dependency from those none spring related modules, and then using profile or a separate dependency pom for managing the spring version.
Modules depends on spring:
ybo@yangbo:~/repos/incubator-servicecomb-java-chassis$ find . -type f -name "pom.xml" -exec grep -l spring {} \; | grep -v demo | grep -v samples | grep -v spring-boot | grep -v tests ./transports/transport-rest/transport-rest-servlet/pom.xml
./archetypes/business-service-jaxrs/target/classes/archetype-resources/pom.xml
./archetypes/business-service-jaxrs/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/target/classes/archetype-resources/pom.xml
./archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/pom.xml
./archetypes/pom.xml
./java-chassis-distribution/pom.xml
./dynamic-config/config-apollo/pom.xml
./parent/pom.xml
./tracing/tracing-zipkin/pom.xml
./tracing/pom.xml
./java-chassis-dependencies/pom.xml
./pom.xml
./handlers/handler-tracing-zipkin/pom.xml
./providers/pom.xml
./providers/provider-springmvc/pom.xml
./coverage-reports/pom.xml
./swagger/swagger-generator/pom.xml
./swagger/swagger-generator/generator-springmvc/pom.xml
./swagger/swagger-invocation/invocation-springmvc/pom.xml
./swagger/swagger-invocation/invocation-core/pom.xml
./swagger/swagger-invocation/pom.xml
./foundations/foundation-config/pom.xml
./foundations/foundation-test-scaffolding/pom.xml
./foundations/foundation-common/pom.xml
On Thu, Sep 13, 2018 at 9:42 AM 郑扬勇 <ya...@qq.com> wrote:
> Hi all:
> Spring boot 2.0 had released for a long time ,so I think we need
> support it as soon as possible.
> Here is our current dependency relationship :
>
> java-chassis [pom]
> ↑
> java-chassis-dependencies(import springboot 1.5.x and spring4.3.x
> etc) [pom] ↑ java-chassis-parent (docker & jacoco plugin etc) [pom]
> ↑ core,edge,handler etc [jar]
>
> So I think we can do like this for support spring boot 2.0:
>
> java-chassis [pom]
> ↑
> * java-chassis-dependencies-springboot2 (FIRST import springboot
> 2.0.x and spring5.0.x ,THEN import java-chassis-dependencies) [pom] ↑
> spring-boot2-starter-servlet(for support Embedded tomcat) etc [jar]
>
> Any thoughts?
> Best Regards & Thanks!
> Yangyong Zheng
--
Best Regards,
Yang.
答复: 回复：答复: [Discuss]Java Chassis Support Spring Boot 2.0
Posted by YangYongZheng <34...@qq.com>.
Of course, I think it is no problem.
Best Regards!
YangYongZheng
-----邮件原件-----
发件人: yhs0092 [mailto:yhs0092@163.com]
发送时间: 2018年9月14日 13:19
收件人: dev@servicecomb.apache.org
主题: 回复：答复: [Discuss]Java Chassis Support Spring Boot 2.0
Hi, Yangyong. I've tried your pull request in my Spring Boot 2 demo and it works well, great job!
I have a little question, can we put spring-boot2-starter-servlet into the dependencyManagement of java-chassis-dependencies-springboot2 so that users only need to introduce one dependency in their project dependencyManagement?
Currently it seems a little bit redundant. See the pom of integration test:
https://github.com/apache/incubator-servicecomb-java-chassis/blob/ae3c92e902b6459bfb76db13c90fe6b5d1044abe/integration-tests/springmvc-tests/springmvc-tests-general-with-springboot2-servlet/pom.xml
Yours sincerely
Yao Haishi
yhs0092@163.com
在2018年9月13日 10:13，YangYongZheng<34...@qq.com> 写道：
Right~, that's better way, but need more works
Best Regards!
YangYongZheng
-----邮件原件-----
发件人: Yang Bo [mailto:oakyang@gmail.com]
发送时间: 2018年9月13日 10:02
收件人: dev@servicecomb.apache.org
主题: Re: [Discuss]Java Chassis Support Spring Boot 2.0
Hi,
It seems to me that just changing the spring/springboot version is not enough. There might be inconsistent implementation details which will require code change between spring 4.x and spring 5.x.
It's better that we remove spring dependency from those none spring related modules, and then using profile or a separate dependency pom for managing the spring version.
Modules depends on spring:
ybo@yangbo:~/repos/incubator-servicecomb-java-chassis$ find . -type f -name "pom.xml" -exec grep -l spring {} \; | grep -v demo | grep -v samples | grep -v spring-boot | grep -v tests ./transports/transport-rest/transport-rest-servlet/pom.xml
./archetypes/business-service-jaxrs/target/classes/archetype-resources/pom.xml
./archetypes/business-service-jaxrs/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/target/classes/archetype-resources/pom.xml
./archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/pom.xml
./archetypes/pom.xml
./java-chassis-distribution/pom.xml
./dynamic-config/config-apollo/pom.xml
./parent/pom.xml
./tracing/tracing-zipkin/pom.xml
./tracing/pom.xml
./java-chassis-dependencies/pom.xml
./pom.xml
./handlers/handler-tracing-zipkin/pom.xml
./providers/pom.xml
./providers/provider-springmvc/pom.xml
./coverage-reports/pom.xml
./swagger/swagger-generator/pom.xml
./swagger/swagger-generator/generator-springmvc/pom.xml
./swagger/swagger-invocation/invocation-springmvc/pom.xml
./swagger/swagger-invocation/invocation-core/pom.xml
./swagger/swagger-invocation/pom.xml
./foundations/foundation-config/pom.xml
./foundations/foundation-test-scaffolding/pom.xml
./foundations/foundation-common/pom.xml
On Thu, Sep 13, 2018 at 9:42 AM 郑扬勇 <ya...@qq.com> wrote:
Hi all:
Spring boot 2.0 had released for a long time ,so I think we need support it as soon as possible.
Here is our current dependency relationship :
java-chassis [pom]
↑
java-chassis-dependencies(import springboot 1.5.x and spring4.3.x
etc) [pom] ↑ java-chassis-parent (docker & jacoco plugin etc) [pom] ↑ core,edge,handler etc [jar]
So I think we can do like this for support spring boot 2.0:
java-chassis [pom]
↑
* java-chassis-dependencies-springboot2 (FIRST import springboot 2.0.x and spring5.0.x ,THEN import java-chassis-dependencies) [pom] ↑ spring-boot2-starter-servlet(for support Embedded tomcat) etc [jar]
Any thoughts?
Best Regards & Thanks!
Yangyong Zheng
--
Best Regards,
Yang.
回复：答复: [Discuss]Java Chassis Support Spring Boot 2.0
Posted by yhs0092 <yh...@163.com>.
Hi, Yangyong. I've tried your pull request in my Spring Boot 2 demo and it works well, great job!
I have a little question, can we put spring-boot2-starter-servlet into the dependencyManagement of java-chassis-dependencies-springboot2 so that users only need to introduce one dependency in their project dependencyManagement?
Currently it seems a little bit redundant. See the pom of integration test:
https://github.com/apache/incubator-servicecomb-java-chassis/blob/ae3c92e902b6459bfb76db13c90fe6b5d1044abe/integration-tests/springmvc-tests/springmvc-tests-general-with-springboot2-servlet/pom.xml
Yours sincerely
Yao Haishi
yhs0092@163.com
在2018年9月13日 10:13，YangYongZheng<34...@qq.com> 写道：
Right~, that's better way, but need more works
Best Regards!
YangYongZheng
-----邮件原件-----
发件人: Yang Bo [mailto:oakyang@gmail.com]
发送时间: 2018年9月13日 10:02
收件人: dev@servicecomb.apache.org
主题: Re: [Discuss]Java Chassis Support Spring Boot 2.0
Hi,
It seems to me that just changing the spring/springboot version is not enough. There might be inconsistent implementation details which will require code change between spring 4.x and spring 5.x.
It's better that we remove spring dependency from those none spring related modules, and then using profile or a separate dependency pom for managing the spring version.
Modules depends on spring:
ybo@yangbo:~/repos/incubator-servicecomb-java-chassis$ find . -type f -name "pom.xml" -exec grep -l spring {} \; | grep -v demo | grep -v samples | grep -v spring-boot | grep -v tests ./transports/transport-rest/transport-rest-servlet/pom.xml
./archetypes/business-service-jaxrs/target/classes/archetype-resources/pom.xml
./archetypes/business-service-jaxrs/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/target/classes/archetype-resources/pom.xml
./archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/pom.xml
./archetypes/pom.xml
./java-chassis-distribution/pom.xml
./dynamic-config/config-apollo/pom.xml
./parent/pom.xml
./tracing/tracing-zipkin/pom.xml
./tracing/pom.xml
./java-chassis-dependencies/pom.xml
./pom.xml
./handlers/handler-tracing-zipkin/pom.xml
./providers/pom.xml
./providers/provider-springmvc/pom.xml
./coverage-reports/pom.xml
./swagger/swagger-generator/pom.xml
./swagger/swagger-generator/generator-springmvc/pom.xml
./swagger/swagger-invocation/invocation-springmvc/pom.xml
./swagger/swagger-invocation/invocation-core/pom.xml
./swagger/swagger-invocation/pom.xml
./foundations/foundation-config/pom.xml
./foundations/foundation-test-scaffolding/pom.xml
./foundations/foundation-common/pom.xml
On Thu, Sep 13, 2018 at 9:42 AM 郑扬勇 <ya...@qq.com> wrote:
Hi all:
Spring boot 2.0 had released for a long time ,so I think we need
support it as soon as possible.
Here is our current dependency relationship :
java-chassis [pom]
↑
java-chassis-dependencies(import springboot 1.5.x and spring4.3.x
etc) [pom] ↑ java-chassis-parent (docker & jacoco plugin etc) [pom]
↑ core,edge,handler etc [jar]
So I think we can do like this for support spring boot 2.0:
java-chassis [pom]
↑
* java-chassis-dependencies-springboot2 (FIRST import springboot
2.0.x and spring5.0.x ,THEN import java-chassis-dependencies) [pom] ↑
spring-boot2-starter-servlet(for support Embedded tomcat) etc [jar]
Any thoughts?
Best Regards & Thanks!
Yangyong Zheng
--
Best Regards,
Yang.