You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cboumalh (via GitHub)" <gi...@apache.org> on 2025/11/02 17:13:50 UTC
[PR] [SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL [spark]
cboumalh opened a new pull request, #52836:
URL: https://github.com/apache/spark/pull/52836
### What changes were proposed in this pull request?
This PR enforces that the sketch configuration parameter (lgConfigK/lgNomEntries) in both HllSketchAgg and ThetaSketchAgg must be a constant value.
If the parameter expression (right) is not foldable, a QueryExecutionErrors.*MustBeConstantError(prettyName) is thrown.
This change ensures that the aggregation configuration is validated at analysis time rather than runtime, preventing inconsistent or invalid sketch behavior.
### Why are the changes needed?
The configuration parameter determines the accuracy and memory footprint of the sketch.
Allowing it to vary dynamically at runtime could lead to nondeterministic aggregation results and incorrect computations.
By enforcing it as a constant expression, we ensure deterministic behavior, predictable memory use, and alignment with the expected semantics of sketch-based aggregations.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added tests in SQLQueryTestSuite
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #52836:
URL: https://github.com/apache/spark/pull/52836#issuecomment-3482396375
Merging to master and 4.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #52836:
URL: https://github.com/apache/spark/pull/52836#issuecomment-3482358384
Looks good, thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor closed pull request #52836: [SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL
URL: https://github.com/apache/spark/pull/52836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL [spark]
Posted by "cboumalh (via GitHub)" <gi...@apache.org>.
cboumalh commented on PR #52836:
URL: https://github.com/apache/spark/pull/52836#issuecomment-3478120596
cc @dtenedor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org