You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2014/04/30 14:51:24 UTC

svn commit: r1591279 - in /lucene/dev/trunk/lucene: CHANGES.txt test-framework/src/java/org/apache/lucene/util/TestRuleLimitSysouts.java

Author: dweiss
Date: Wed Apr 30 12:51:24 2014
New Revision: 1591279

URL: http://svn.apache.org/r1591279
Log:
Follow up cleanups to LUCENE-5622.

Modified:
    lucene/dev/trunk/lucene/CHANGES.txt
    lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleLimitSysouts.java

Modified: lucene/dev/trunk/lucene/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/CHANGES.txt?rev=1591279&r1=1591278&r2=1591279&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/CHANGES.txt (original)
+++ lucene/dev/trunk/lucene/CHANGES.txt Wed Apr 30 12:51:24 2014
@@ -123,6 +123,11 @@ Bug fixes
 * LUCENE-5559: Add additional argument validation for CapitalizationFilter
   and CodepointCountFilter. (Ahmet Arslan via Robert Muir)
 
+Test Framework
+
+* LUCENE-5622: Fail tests if they print over the given limit of bytes to 
+  System.out or System.err. (Robert Muir, Dawid Weiss)
+
 ======================= Lucene 4.8.0 =======================
 
 System Requirements

Modified: lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleLimitSysouts.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleLimitSysouts.java?rev=1591279&r1=1591278&r2=1591279&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleLimitSysouts.java (original)
+++ lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleLimitSysouts.java Wed Apr 30 12:51:24 2014
@@ -192,8 +192,8 @@ public class TestRuleLimitSysouts extend
   }
 
   /**
-   * We're only interested in failing the suite if it was successful. Otherwise
-   * just propagate the original problem and don't bother.
+   * We're only interested in failing the suite if it was successful (otherwise
+   * just propagate the original problem and don't bother doing anything else).
    */
   @Override
   protected void afterIfSuccessful() throws Throwable {
@@ -219,9 +219,6 @@ public class TestRuleLimitSysouts extend
     }
   }
 
-  /**
-   * Restore original streams.
-   */
   @Override
   protected void afterAlways(List<Throwable> errors) throws Throwable {
     resetCaptureState();