You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/02 00:12:21 UTC
[GitHub] [superset] yousoph commented on pull request #19314: feat: Move Database Import option into DB Connection modal
yousoph commented on pull request #19314:
URL: https://github.com/apache/superset/pull/19314#issuecomment-1086424570
> let's test for a 500 error. I got a toast once, but not the second time. What should be the state of the modal on a 500? Stay on screen 1  ?
Close modal and show error toast (in the future we should revisit showing errors on the modal itself)
Re: Import being not as discoverable - we don't think this is a primary action so we're ok with it as is for now (once it's updated to 14px instead of 13px). Dashboard imports will be more common than db ones, but we can revisit later if we get more feedback that it's hard to find!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org