[GitHub] [spark] viirya commented on a change in pull request #35080: [SPARK-37792][CORE] Fix the check of custom configuration in SparkShellLoggingFilter

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #35080:
URL: https://github.com/apache/spark/pull/35080#discussion_r776977248



##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -266,6 +266,10 @@ private[spark] object Logging {
       }
     }
 
+    private def loggerWithoutConfig(logger: Log4jLogger): Boolean = {

Review comment:
       Hm? Not sure if I understand your concern. This check doesn't rely on the configuration of root logger. It only checks if the logger uses same LogConfig as root logger. Based on log4j2 architecture, if the logger has custom config, it will have a different LogConfig.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org