[GitHub] [beam] robertwb commented on a diff in pull request #25313: Fail the pipeline when a mismatched Python version is detected.

["robertwb (via GitHub)" <gi...@apache.org>]

robertwb commented on code in PR #25313:
URL: https://github.com/apache/beam/pull/25313#discussion_r1097760889


##########
sdks/python/apache_beam/runners/worker/bundle_processor.py:
##########
@@ -823,6 +825,38 @@ def only_element(iterable):
   return element
 
 
+def _extract_py_version(capability):
+  return capability[len(_PY_SDK_CAPABILITY_PREFIX):].split("_sdk:")[0]
+
+
+def _verify_descriptor_created_in_a_compatible_env(process_bundle_descriptor):
+  # type: beam_fn_api_pb2.ProcessBundleDescriptor -> None
+
+  py_envs_at_submission = set()
+  for _, env in process_bundle_descriptor.environments.items():

Review Comment:
   Rather than enumerating over all environments, just enumerate over the environments associated with the transforms of this bundle descriptor such that we can require an exact match. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org