You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by zhaakhi <gi...@git.apache.org> on 2017/07/31 10:45:57 UTC

[GitHub] thrift pull request #1321: THRIFT-4274: Catch OSError in TSSLServerSocket.ac...

GitHub user zhaakhi opened a pull request:

    https://github.com/apache/thrift/pull/1321

    THRIFT-4274: Catch OSError in TSSLServerSocket.accept()

    wrap_socket can raise OSError instead of SSLError when receiving an
    invalid connection attempt, which if not caught crashes TSimpleServer
    and causes the feature tests to fail.
    
    This only seems to happen on newer versions of either OpenSSL or Python, so the Travis tests would not catch this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhaakhi/thrift THRIFT-4274

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1321
    
----
commit b4e9c8b5726c0f7fa9de314fb452073f3d36bc61
Author: Håkon Hitland <ha...@zedge.net>
Date:   2017-07-31T10:39:52Z

    THRIFT-4274: Catch OSError in TSSLServerSocket.accept()
    
    wrap_socket can raise OSError instead of SSLError when receiving an
    invalid connection attempt, which if not caught crashes TSimpleServer
    and causes the feature tests to fail.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1321: THRIFT-4274: Catch OSError in TSSLServerSocket.ac...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1321


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---