You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by Simon Kitching <sk...@obsidium.com> on 2005/11/10 22:51:22 UTC

HtmlInputDate change breaks unit test

Hi,

In directory tomahawk/test, the class
   org.apache.myfaces.custom.date.HtmlDateRenderCactus
currently fails to compile.

Command "ant unit-test" will show this, but not "ant dist".

r332339 (fix for MYFACES-238) for class HtmlInputDate appears to have 
caused this problem.

Regards,

Simon

Re: HtmlInputDate change breaks unit test

Posted by Martin Marinschek <ma...@gmail.com>.

should be fixed.

regards,

Martin

On 11/11/05, Simon Kitching <sk...@obsidium.com> wrote:
> Simon Kitching wrote:
> > Hi,
> >
> > In directory tomahawk/test, the class
> >   org.apache.myfaces.custom.date.HtmlDateRenderCactus
> > currently fails to compile.
> >
> > Command "ant unit-test" will show this, but not "ant dist".
> >
> > r332339 (fix for MYFACES-238) for class HtmlInputDate appears to have
> > caused this problem.
> >
>
> There's also a compilation problem in
>    org.apache.myfaces.custom.date.HtmlDateRenderer
> method
>    encodeAmpmChoice
> line 211.
>
> The code:
>     writer.writeAttribute(HTML.VALUE_ATTR, calendar_ampm, null);
> only compiles under java 1.5, as the second param to writeAttribute
> takes an Object (java 1.5 autoboxing makes this work).
>
> Regards,
>
> Simon
>


--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Re: HtmlInputDate change breaks unit test

Posted by Simon Kitching <sk...@obsidium.com>.

Simon Kitching wrote:
> Hi,
> 
> In directory tomahawk/test, the class
>   org.apache.myfaces.custom.date.HtmlDateRenderCactus
> currently fails to compile.
> 
> Command "ant unit-test" will show this, but not "ant dist".
> 
> r332339 (fix for MYFACES-238) for class HtmlInputDate appears to have 
> caused this problem.
> 

There's also a compilation problem in
   org.apache.myfaces.custom.date.HtmlDateRenderer
method
   encodeAmpmChoice
line 211.

The code:
    writer.writeAttribute(HTML.VALUE_ATTR, calendar_ampm, null);
only compiles under java 1.5, as the second param to writeAttribute 
takes an Object (java 1.5 autoboxing makes this work).

Regards,

Simon