You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/30 10:13:09 UTC

[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1642: DataSourceMapperTest UT modify #1465

qiaozhanwei opened a new pull request #1642: DataSourceMapperTest UT modify #1465
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1642
 
 
   DataSourceMapperTest UT modify

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] khadgarmage merged pull request #1642: DataSourceMapperTest UT modify #1465

Posted by GitBox <gi...@apache.org>.
khadgarmage merged pull request #1642: DataSourceMapperTest UT modify #1465
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1642
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1642: DataSourceMapperTest UT modify #1465

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1642: DataSourceMapperTest UT modify #1465
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1642#issuecomment-569634933
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`dev@426c027`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=tree)
   
   ```diff
   @@          Coverage Diff          @@
   ##             dev   #1642   +/-   ##
   =====================================
     Coverage       ?   13.4%           
   =====================================
     Files          ?     282           
     Lines          ?   13915           
     Branches       ?    2250           
   =====================================
     Hits           ?    1866           
     Misses         ?   11843           
     Partials       ?     206
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=footer). Last update [426c027...5ef468b](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1642: DataSourceMapperTest UT modify #1465

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1642: DataSourceMapperTest UT modify #1465
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1642#issuecomment-569634933
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=h1) Report
   > Merging [#1642](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1ced26478158741efd7c4b11dc8d96e9b86f2d37?src=pr&el=desc) will **increase** coverage by `5.29%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1642      +/-   ##
   ========================================
   + Coverage   8.11%   13.4%   +5.29%     
   ========================================
     Files        282     282              
     Lines      13924   13915       -9     
     Branches    2254    2250       -4     
   ========================================
   + Hits        1130    1866     +736     
   + Misses     12676   11843     -833     
   - Partials     118     206      +88
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...olphinscheduler/api/controller/BaseController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQmFzZUNvbnRyb2xsZXIuamF2YQ==) | `3.65% <0%> (+3.65%)` | :arrow_up: |
   | [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `45.83% <0%> (+8.33%)` | :arrow_up: |
   | [...e/dolphinscheduler/api/service/MonitorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTW9uaXRvclNlcnZpY2UuamF2YQ==) | `16.12% <0%> (+16.12%)` | :arrow_up: |
   | [...rg/apache/dolphinscheduler/api/utils/PageInfo.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1BhZ2VJbmZvLmphdmE=) | `37.5% <0%> (+37.5%)` | :arrow_up: |
   | [...e/dolphinscheduler/api/service/SessionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvU2Vzc2lvblNlcnZpY2UuamF2YQ==) | `52.77% <0%> (+52.77%)` | :arrow_up: |
   | [...ache/dolphinscheduler/api/service/BaseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQmFzZVNlcnZpY2UuamF2YQ==) | `55.55% <0%> (+55.55%)` | :arrow_up: |
   | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `72.89% <0%> (+72.89%)` | :arrow_up: |
   | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `73.57% <0%> (+73.57%)` | :arrow_up: |
   | [...che/dolphinscheduler/api/service/QueueService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUXVldWVTZXJ2aWNlLmphdmE=) | `75.51% <0%> (+75.51%)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=footer). Last update [1ced264...5ef468b](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1642?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services