You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by "Bruce Schuchardt (JIRA)" <ji...@apache.org> on 2017/03/17 16:59:42 UTC

[jira] [Created] (GEODE-2684) org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup

Bruce Schuchardt created GEODE-2684:
---------------------------------------

             Summary: org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup
                 Key: GEODE-2684
                 URL: https://issues.apache.org/jira/browse/GEODE-2684
             Project: Geode
          Issue Type: Bug
          Components: membership
            Reporter: Bruce Schuchardt


These classes contain a lot of commented-out code, poorly named methods and incorrect calculations that need to be cleaned up.  For instance, Connection contains this:

short aShort = -1;
bytes[x] = (byte)(aShort & 0xff / 0x100);
bytes[x+1] = (byte)(aShort & 0xff);

which is incorrect and results in bytes[x] being zero when the intent is for it to be 255.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)