[GitHub] [flink] maosuhan commented on a diff in pull request #23162: [FLINK-32650][protobuf]Added the ability to split flink-protobuf code…

["maosuhan (via GitHub)" <gi...@apache.org>]

maosuhan commented on code in PR #23162:
URL: https://github.com/apache/flink/pull/23162#discussion_r1313212839


##########
flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/deserialize/PbCodegenRowDeserializer.java:
##########
@@ -100,6 +102,85 @@ public String codegen(String resultVar, String pbObjectCode, int indent)
         return appender.code();
     }
 
+    @Override
+    public String codegenSplit(

Review Comment:
   @ljw-hit Could you explain more about internal connection methods? Though it is more flexible to keep two codegen methods but I cannot see much benefit to do that. Too much duplicate codes also increase the maintenance overhead. Will the performance of original codegen method surpass the splitable methods in some cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org