[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4640: Added disk provisioning type support for VMWare

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r569116418



##########
File path: engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -207,6 +215,13 @@ protected boolean filter(ExcludeList avoid, StoragePool pool, DiskProfile dskCh,
             return false;
         }
 
+        if (diskProvisioningTypeStrictness){

Review comment:
       as mentioned above, please use direct configkey object with valueIn() method

##########
File path: engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -82,6 +86,10 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
             if (allocationAlgorithm != null) {
                 this.allocationAlgorithm = allocationAlgorithm;
             }
+            String strictness = configs.get("disk.provisioning.type.strictness");

Review comment:
       "disk.provisioning.type.strictness" is defined as dynamic and zone level configuration parameter. Getting the value from 'configs' and using a variable in configure() method will not make it dynamic or read from specific zone. Please use ConfigKey object with valuein() method to get the value at the exact usage point.

##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStorageCapabilitiesCmd.java
##########
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.storage;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.StoragePoolResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+@APICommand(name = UpdateStorageCapabilitiesCmd.APINAME, description = "Syncs hardware acceleration capabilities of storage pools",

Review comment:
       @Spaceman1984 Can you please help me in understanding why we need a new API to update hardware acceleration. In the implementation of this also we are finally using ModifyStoragePoolCommand. 
   I think keeping the storage pool in maintenance and mode and cancelling the maintenance mode will trigger ModifyStoragePool Command and that should be good enough to fetch hardware acceleration details if at all that is changed on datastore. 
   Please let me know if anything I'm missing here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org