You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Daniel Dominguez (JIRA)" <ji...@apache.org> on 2009/07/13 18:01:15 UTC
[jira] Created: (ODE-635) Propagate DeploymentException when SA
deployment fails.
Propagate DeploymentException when SA deployment fails.
-------------------------------------------------------
Key: ODE-635
URL: https://issues.apache.org/jira/browse/ODE-635
Project: ODE
Issue Type: Improvement
Components: JBI Integration
Affects Versions: 1.3.2, 1.3.3, 2.0
Environment: ServiceMix 4
Reporter: Daniel Dominguez
Attachments: ODE-635.patch
I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and undeploy method in OdeSUManager does not throw a DeploymentException when there is a problem with a service assembly (i.e. bad deploy.xml). In contrast the start and stop methods both throw DeploymentException when appropriate.
The problem this causes for me is that when I attempt to deploy and start a service assembly, the deploy appears to succeed but the start returns an unrelated error which is difficult to diagnose.
I've created a simple patch which will throw the DeploymentException instead of an error string which is ignored by smx4.
Is this a reasonable approach?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-635) Propagate DeploymentException when SA
deployment fails.
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731716#action_12731716 ]
Alex Boisvert commented on ODE-635:
-----------------------------------
Ok, in that case I'm going to close this issue unless there's a compelling reason to throw a DeploymentException. Any objections?
> Propagate DeploymentException when SA deployment fails.
> -------------------------------------------------------
>
> Key: ODE-635
> URL: https://issues.apache.org/jira/browse/ODE-635
> Project: ODE
> Issue Type: Improvement
> Components: JBI Integration
> Affects Versions: 1.3.2, 1.3.3, 2.0
> Environment: ServiceMix 4
> Reporter: Daniel Dominguez
> Attachments: ODE-635.patch
>
>
> I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and undeploy method in OdeSUManager does not throw a DeploymentException when there is a problem with a service assembly (i.e. bad deploy.xml). In contrast the start and stop methods both throw DeploymentException when appropriate.
> The problem this causes for me is that when I attempt to deploy and start a service assembly, the deploy appears to succeed but the start returns an unrelated error which is difficult to diagnose.
> I've created a simple patch which will throw the DeploymentException instead of an error string which is ignored by smx4.
> Is this a reasonable approach?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-635) Propagate DeploymentException when SA
deployment fails.
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730576#action_12730576 ]
Alex Boisvert commented on ODE-635:
-----------------------------------
The JBI spec is not very good at clarifying what the behavior should be... It says among other things,
A failed deployment of the service unit must be reported using the component-task-result element
as well; the task-result must be set to FAILED. (page 131)
but also says that the deploy() method,
Throws:
javax.jbi.management.DeploymentException141 - if the deployment operation is
unsuccessful. (page 132)
As well as,
Components supply status/result strings as XML strings that conform to the component-task-result-details type
from the above schema. For example, the ServiceUnitManager.deploy() method returns such a status/
result string. The JBI implementation MUST combine the status/result strings supplied by components into the
the overall status/result document defined above. (page 86)
So it's difficult to determine which behavior is correct...
> Propagate DeploymentException when SA deployment fails.
> -------------------------------------------------------
>
> Key: ODE-635
> URL: https://issues.apache.org/jira/browse/ODE-635
> Project: ODE
> Issue Type: Improvement
> Components: JBI Integration
> Affects Versions: 1.3.2, 1.3.3, 2.0
> Environment: ServiceMix 4
> Reporter: Daniel Dominguez
> Attachments: ODE-635.patch
>
>
> I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and undeploy method in OdeSUManager does not throw a DeploymentException when there is a problem with a service assembly (i.e. bad deploy.xml). In contrast the start and stop methods both throw DeploymentException when appropriate.
> The problem this causes for me is that when I attempt to deploy and start a service assembly, the deploy appears to succeed but the start returns an unrelated error which is difficult to diagnose.
> I've created a simple patch which will throw the DeploymentException instead of an error string which is ignored by smx4.
> Is this a reasonable approach?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-635) Propagate DeploymentException when SA
deployment fails.
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved ODE-635.
-------------------------------
Resolution: Won't Fix
> Propagate DeploymentException when SA deployment fails.
> -------------------------------------------------------
>
> Key: ODE-635
> URL: https://issues.apache.org/jira/browse/ODE-635
> Project: ODE
> Issue Type: Improvement
> Components: JBI Integration
> Affects Versions: 1.3.2, 1.3.3, 2.0
> Environment: ServiceMix 4
> Reporter: Daniel Dominguez
> Attachments: ODE-635.patch
>
>
> I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and undeploy method in OdeSUManager does not throw a DeploymentException when there is a problem with a service assembly (i.e. bad deploy.xml). In contrast the start and stop methods both throw DeploymentException when appropriate.
> The problem this causes for me is that when I attempt to deploy and start a service assembly, the deploy appears to succeed but the start returns an unrelated error which is difficult to diagnose.
> I've created a simple patch which will throw the DeploymentException instead of an error string which is ignored by smx4.
> Is this a reasonable approach?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-635) Propagate DeploymentException when SA
deployment fails.
Posted by "Daniel Dominguez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731718#action_12731718 ]
Daniel Dominguez commented on ODE-635:
--------------------------------------
No objections from me
> Propagate DeploymentException when SA deployment fails.
> -------------------------------------------------------
>
> Key: ODE-635
> URL: https://issues.apache.org/jira/browse/ODE-635
> Project: ODE
> Issue Type: Improvement
> Components: JBI Integration
> Affects Versions: 1.3.2, 1.3.3, 2.0
> Environment: ServiceMix 4
> Reporter: Daniel Dominguez
> Attachments: ODE-635.patch
>
>
> I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and undeploy method in OdeSUManager does not throw a DeploymentException when there is a problem with a service assembly (i.e. bad deploy.xml). In contrast the start and stop methods both throw DeploymentException when appropriate.
> The problem this causes for me is that when I attempt to deploy and start a service assembly, the deploy appears to succeed but the start returns an unrelated error which is difficult to diagnose.
> I've created a simple patch which will throw the DeploymentException instead of an error string which is ignored by smx4.
> Is this a reasonable approach?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-635) Propagate DeploymentException when SA
deployment fails.
Posted by "Daniel Dominguez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dominguez updated ODE-635:
---------------------------------
Attachment: ODE-635.patch
patch file
> Propagate DeploymentException when SA deployment fails.
> -------------------------------------------------------
>
> Key: ODE-635
> URL: https://issues.apache.org/jira/browse/ODE-635
> Project: ODE
> Issue Type: Improvement
> Components: JBI Integration
> Affects Versions: 1.3.2, 1.3.3, 2.0
> Environment: ServiceMix 4
> Reporter: Daniel Dominguez
> Attachments: ODE-635.patch
>
>
> I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and undeploy method in OdeSUManager does not throw a DeploymentException when there is a problem with a service assembly (i.e. bad deploy.xml). In contrast the start and stop methods both throw DeploymentException when appropriate.
> The problem this causes for me is that when I attempt to deploy and start a service assembly, the deploy appears to succeed but the start returns an unrelated error which is difficult to diagnose.
> I've created a simple patch which will throw the DeploymentException instead of an error string which is ignored by smx4.
> Is this a reasonable approach?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-635) Propagate DeploymentException when SA
deployment fails.
Posted by "Greg Lucas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731606#action_12731606 ]
Greg Lucas commented on ODE-635:
--------------------------------
I've filed a ServiceMix 4 issue related to this: SMX4-321
ServiceMix 3 handles either the DeploymentException or the FAILED task-result, while in SMX4 the task-result is ignored. This looks wrong given that the spec implies either approach can be used to signal a deployment failure. (See also <http://forums.sun.com/thread.jspa?threadID=688608> which supports this interpretation of the spec.)
> Propagate DeploymentException when SA deployment fails.
> -------------------------------------------------------
>
> Key: ODE-635
> URL: https://issues.apache.org/jira/browse/ODE-635
> Project: ODE
> Issue Type: Improvement
> Components: JBI Integration
> Affects Versions: 1.3.2, 1.3.3, 2.0
> Environment: ServiceMix 4
> Reporter: Daniel Dominguez
> Attachments: ODE-635.patch
>
>
> I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and undeploy method in OdeSUManager does not throw a DeploymentException when there is a problem with a service assembly (i.e. bad deploy.xml). In contrast the start and stop methods both throw DeploymentException when appropriate.
> The problem this causes for me is that when I attempt to deploy and start a service assembly, the deploy appears to succeed but the start returns an unrelated error which is difficult to diagnose.
> I've created a simple patch which will throw the DeploymentException instead of an error string which is ignored by smx4.
> Is this a reasonable approach?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.