[GitHub] [incubator-superset] junlincc commented on pull request #11418: feat(explore): time picker enhancement

[GitBox <gi...@apache.org>]

junlincc commented on pull request #11418:
URL: https://github.com/apache/incubator-superset/pull/11418#issuecomment-747532911


   > 1. Is there a reason why this does not include "Previous Calendar Quarter"?
   
   sure we can add "previous calendar quarter". Cartel designer did mentioned companies define their quarter differently. 
   
   for the rest of the styling issues pointed @zhaoyongjie please straightly follow the design spec to make the changes. 
   https://www.figma.com/file/JWaGztdhZS0kS5ruG7x9tB/Control-Panel?node-id=195%3A36068
   
   <img width="563" alt="Screen Shot 2020-12-17 at 8 00 24 AM" src="https://user-images.githubusercontent.com/67837651/102511734-ff93ef80-403d-11eb-8888-412bc674740b.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org