You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2010/05/01 17:45:53 UTC

what's up with r842347's log message?

The log on r842347 (aka r2273) looks wrong. What happened to it?

With some sleuthing, I found the log message *should* look like:
  http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=80079

So where/how did it get monkeyed? And even worse: what others may be
clipped like that?

Cheers,
-g

Re: what's up with r842347's log message?

Posted by Greg Stein <gs...@gmail.com>.
Eep!

Local bug. It was trimming the log message :-(


On Sat, May 1, 2010 at 13:49, Stefan Sperling <st...@elego.de> wrote:
> On Sat, May 01, 2010 at 01:45:53PM -0400, Greg Stein wrote:
>> The log on r842347 (aka r2273) looks wrong. What happened to it?
>
> What are you seeing?
>
> I'm getting:
>
> ------------------------------------------------------------------------
> r842347 | cmpilato | 2002-06-18 22:14:56 +0200 (Tue, 18 Jun 2002) | 38 lines
>
> Make and populate subdirectories for Berkeley DB stuff and some
> database utils under the libsvn_fs directory.  This required patching
> up many other files' #include lines, too.
>
> * subversion/libsvn_fs/bdb
>  New directory for Berkeley DB-specific source code.  Also set the
>  svn:ignore property here.
>
> * subversion/libsvn_fs/util
>  New directory for filesystem utilities source code.  Also set the
>  svn:ignore property here.
>
> * subversion/libsvn_fs/bdb/copies-table.c
> * subversion/libsvn_fs/bdb/copies-table.h
> * subversion/libsvn_fs/bdb/rev-table.c
> * subversion/libsvn_fs/bdb/rev-table.h
> * subversion/libsvn_fs/bdb/txn-table.c
> * subversion/libsvn_fs/bdb/txn-table.h
> * subversion/libsvn_fs/bdb/reps-table.c
> * subversion/libsvn_fs/bdb/reps-table.h
> * subversion/libsvn_fs/bdb/strings-table.c
> * subversion/libsvn_fs/bdb/strings-table.h
> * subversion/libsvn_fs/bdb/nodes-table.c
> * subversion/libsvn_fs/bdb/nodes-table.h
> * subversion/libsvn_fs/bdb/dbt.c
> * subversion/libsvn_fs/bdb/dbt.h
>  Moved from subversion/libsvn_fs.
>
> * subversion/libsvn_fs/util/skel.c
> * subversion/libsvn_fs/util/skel.h
> * subversion/libsvn_fs/util/fs_skels.c
> * subversion/libsvn_fs/util/fs_skels.h
>  Moved from subversion/libsvn_fs.
>
> * subversion/libsvn_fs/structure
>  Update this document with near-future plans for the filesystem.
>
>
> ------------------------------------------------------------------------
>
>
> ... which looks as expected?
>
> Stefan
>

Re: what's up with r842347's log message?

Posted by Stefan Sperling <st...@elego.de>.
On Sat, May 01, 2010 at 01:45:53PM -0400, Greg Stein wrote:
> The log on r842347 (aka r2273) looks wrong. What happened to it?

What are you seeing?

I'm getting:

------------------------------------------------------------------------
r842347 | cmpilato | 2002-06-18 22:14:56 +0200 (Tue, 18 Jun 2002) | 38 lines

Make and populate subdirectories for Berkeley DB stuff and some
database utils under the libsvn_fs directory.  This required patching
up many other files' #include lines, too.

* subversion/libsvn_fs/bdb
  New directory for Berkeley DB-specific source code.  Also set the
  svn:ignore property here.

* subversion/libsvn_fs/util
  New directory for filesystem utilities source code.  Also set the
  svn:ignore property here.

* subversion/libsvn_fs/bdb/copies-table.c
* subversion/libsvn_fs/bdb/copies-table.h
* subversion/libsvn_fs/bdb/rev-table.c
* subversion/libsvn_fs/bdb/rev-table.h
* subversion/libsvn_fs/bdb/txn-table.c
* subversion/libsvn_fs/bdb/txn-table.h
* subversion/libsvn_fs/bdb/reps-table.c
* subversion/libsvn_fs/bdb/reps-table.h
* subversion/libsvn_fs/bdb/strings-table.c
* subversion/libsvn_fs/bdb/strings-table.h
* subversion/libsvn_fs/bdb/nodes-table.c
* subversion/libsvn_fs/bdb/nodes-table.h
* subversion/libsvn_fs/bdb/dbt.c
* subversion/libsvn_fs/bdb/dbt.h
  Moved from subversion/libsvn_fs.

* subversion/libsvn_fs/util/skel.c
* subversion/libsvn_fs/util/skel.h
* subversion/libsvn_fs/util/fs_skels.c
* subversion/libsvn_fs/util/fs_skels.h
  Moved from subversion/libsvn_fs.

* subversion/libsvn_fs/structure
  Update this document with near-future plans for the filesystem.


------------------------------------------------------------------------


... which looks as expected?

Stefan

Re: what's up with r842347's log message?

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Greg Stein wrote on Sat, 1 May 2010 at 13:45 -0400:
> With some sleuthing, I found the log message *should* look like:
>   http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=80079
> 
> So where/how did it get monkeyed? And even worse: what others may be
> clipped like that?
> 

That was a CRLF-to-LF change.  Mike mass-converted several hundred log
messages that day (because it broke svnsync, because we started
enforcing \n-ness of svn:* properties in libsvn_repos, because there
were bug reports in that area).

> Cheers,
> -g
>