You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Tom Jordahl (JIRA)" <ji...@apache.org> on 2005/09/09 15:45:30 UTC

[jira] Created: (AXIS2-211) All printStackTrace() calls should be removed

All printStackTrace() calls should be removed
---------------------------------------------

         Key: AXIS2-211
         URL: http://issues.apache.org/jira/browse/AXIS2-211
     Project: Apache Axis 2.0 (Axis2)
        Type: Bug
    Reporter: Tom Jordahl
    Priority: Minor


Recently some code was checked in to the Axis2 tree that included code like the following:

catch (Exception e) {
  e.printStackTrace();
  throw new BadThingHappened();
}

Printing the stack trace to stdout is not nice when Axis is embeded in to some other system.  The trace should either be logged or ignored and the original exception should probably be preserved in the newly throw exception.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS2-211) All printStackTrace() calls should be removed

Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2-211?page=comments#action_12323063 ] 

Eran Chinthaka commented on AXIS2-211:
--------------------------------------

I removed all the printStacktraces from the code, but still there are some in the Test classes. Are we keeping them or removing them too .... Just asking to know your ideas before removing them 

> All printStackTrace() calls should be removed
> ---------------------------------------------
>
>          Key: AXIS2-211
>          URL: http://issues.apache.org/jira/browse/AXIS2-211
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>     Reporter: Tom Jordahl
>     Priority: Minor

>
> Recently some code was checked in to the Axis2 tree that included code like the following:
> catch (Exception e) {
>   e.printStackTrace();
>   throw new BadThingHappened();
> }
> Printing the stack trace to stdout is not nice when Axis is embeded in to some other system.  The trace should either be logged or ignored and the original exception should probably be preserved in the newly throw exception.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (AXIS2-211) All printStackTrace() calls should be removed

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-211?page=all ]
     
Davanum Srinivas resolved AXIS2-211:
------------------------------------

    Resolution: Fixed

i think we've fixed all spots that exist...

> All printStackTrace() calls should be removed
> ---------------------------------------------
>
>          Key: AXIS2-211
>          URL: http://issues.apache.org/jira/browse/AXIS2-211
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>     Reporter: Tom Jordahl
>     Priority: Minor

>
> Recently some code was checked in to the Axis2 tree that included code like the following:
> catch (Exception e) {
>   e.printStackTrace();
>   throw new BadThingHappened();
> }
> Printing the stack trace to stdout is not nice when Axis is embeded in to some other system.  The trace should either be logged or ignored and the original exception should probably be preserved in the newly throw exception.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS2-211) All printStackTrace() calls should be removed

Posted by "Sanjiva Weerawarana (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2-211?page=comments#action_12323100 ] 

Sanjiva Weerawarana commented on AXIS2-211:
-------------------------------------------

+1 for removing them too.

> All printStackTrace() calls should be removed
> ---------------------------------------------
>
>          Key: AXIS2-211
>          URL: http://issues.apache.org/jira/browse/AXIS2-211
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>     Reporter: Tom Jordahl
>     Priority: Minor

>
> Recently some code was checked in to the Axis2 tree that included code like the following:
> catch (Exception e) {
>   e.printStackTrace();
>   throw new BadThingHappened();
> }
> Printing the stack trace to stdout is not nice when Axis is embeded in to some other system.  The trace should either be logged or ignored and the original exception should probably be preserved in the newly throw exception.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS2-211) All printStackTrace() calls should be removed

Posted by "Tom Jordahl (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2-211?page=comments#action_12323252 ] 

Tom Jordahl commented on AXIS2-211:
-----------------------------------

If we are printing stack traces when tests *fail*, then this is a good thing.  I don't think you can have too much info in that case.


> All printStackTrace() calls should be removed
> ---------------------------------------------
>
>          Key: AXIS2-211
>          URL: http://issues.apache.org/jira/browse/AXIS2-211
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>     Reporter: Tom Jordahl
>     Priority: Minor

>
> Recently some code was checked in to the Axis2 tree that included code like the following:
> catch (Exception e) {
>   e.printStackTrace();
>   throw new BadThingHappened();
> }
> Printing the stack trace to stdout is not nice when Axis is embeded in to some other system.  The trace should either be logged or ignored and the original exception should probably be preserved in the newly throw exception.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira