You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/11/22 17:55:35 UTC
Review Request 64036: Log Search UI: refine time range picker
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64036/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-22503
https://issues.apache.org/jira/browse/AMBARI-22503
Repository: ambari
Description
-------
1. Values of time picker inputs should be synced with the selected time range.
2. Label of toggle button should contain 'Custom' text when custom range is specified with the time pickers.
Diffs
-----
ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.spec.ts e6c0bfe
ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.ts efb5e34
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.html 621f995
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.ts cacabc3
ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts 90ab9b7
ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json b214a4f
Diff: https://reviews.apache.org/r/64036/diff/1/
Testing
-------
Executed 211 of 211 SUCCESS (4.731 secs / 4.643 secs)
Thanks,
Andrii Babiichuk
Re: Review Request 64036: Log Search UI: refine time range picker
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64036/#review191749
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Ноя. 22, 2017, 5:55 п.п., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64036/
> -----------------------------------------------------------
>
> (Updated Ноя. 22, 2017, 5:55 п.п.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-22503
> https://issues.apache.org/jira/browse/AMBARI-22503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Values of time picker inputs should be synced with the selected time range.
> 2. Label of toggle button should contain 'Custom' text when custom range is specified with the time pickers.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.spec.ts e6c0bfe
> ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.ts efb5e34
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.html 621f995
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.ts cacabc3
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts 90ab9b7
> ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json b214a4f
>
>
> Diff: https://reviews.apache.org/r/64036/diff/1/
>
>
> Testing
> -------
>
> Executed 211 of 211 SUCCESS (4.731 secs / 4.643 secs)
>
>
> Thanks,
>
> Andrii Babiichuk
>
>