You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "cchung100m (via GitHub)" <gi...@apache.org> on 2023/07/18 15:45:27 UTC

[GitHub] [incubator-uniffle] cchung100m commented on a diff in pull request #1017: [#973] improvement: Make shuffle manager client RPC timeout configurable

cchung100m commented on code in PR #1017:
URL: https://github.com/apache/incubator-uniffle/pull/1017#discussion_r1266973371


##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -129,6 +129,12 @@ public class RssBaseConf extends RssConf {
           .defaultValue(ClientType.GRPC)
           .withDescription("client type for rss");
 
+  public static final ConfigOption<Long> RSS_CLIENT_TYPE_GRPC_TIMEOUT =
+      ConfigOptions.key("rss.rpc.client.type.grpc.timeout")
+          .longType()

Review Comment:
   Hi @jerqi  @zuston 
   
   Thanks for the prompt reply and I updated the part you mentioned.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org