[jira] [Commented] (OOZIE-3379) Auth token cache file name should include Oozie URL

["Andras Piros (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676463#comment-16676463 ] 

Andras Piros commented on OOZIE-3379:
-------------------------------------

Thanks for the contribution [~zuston]!

A couple of comments:
 # file length should be trimmed to 255 chars
 # if there is already a {{File}} with the same name, at least {{LOG.warn()}}
 # new unit test cases covering the new functionality should be created, explicitly testing for multiple {{AuthOozieClient}} instances in one JVM
 # instead of {{public static File}}, the auth token cache should be {{@VisibleForTesting final File}} that could be asserted in a unit test. In a JVM we can have multiple {{AuthOozieClient}} instances w/ multiple Oozie URLs, that's also why we should not use {{static}} here

> Auth token cache file name should include Oozie URL
> ---------------------------------------------------
>
>                 Key: OOZIE-3379
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3379
>             Project: Oozie
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 5.0.0
>            Reporter: ZhangJunfan
>            Assignee: ZhangJunfan
>            Priority: Major
>         Attachments: oozie-3379-1.patch
>
>
> We have a program that uses the oozie client, but when the client connects to multiple clusters,
> the authOozieClient class frequently requests the kdc server because the authentication token cache file is invalid.
> This will cause subsequent requests in our program to be blocked, resulting in unstable services.
> So, oozie client's auth token cache file name should include Oozie URL.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)