You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/05 18:49:31 UTC

[GitHub] [apisix] swayamraina commented on a change in pull request #1961: add apisix-version info to headers

swayamraina commented on a change in pull request #1961:
URL: https://github.com/apache/apisix/pull/1961#discussion_r465932770



##########
File path: apisix/init.lua
##########
@@ -299,6 +300,8 @@ function _M.http_access_phase()
 
     core.ctx.set_vars_meta(api_ctx)
 
+    core.response.set_header("server", ver_header)

Review comment:
       Agreed. Moreover `X-Version : 1.4` does not convey any information related to `apisix`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org