You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/07/16 13:28:46 UTC
[GitHub] flink pull request #6342: [FLINK-9748][release] Use dedicated directory for ...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6342
[FLINK-9748][release] Use dedicated directory for release artifacts
## What is the purpose of the change
With this PR artifacts created during the release process are no longer placed in the root flink directory, but instead a dedicated directory under `/tools/releasing`.
This makes it easier to reset the repository state in case of an error, as all you have to do is remove said directory. It also prevents accidentally committing release files.
In case of success this directory will contain all release artifacts that should be uploaded.
Additionally this PR introduces variables for commonly used directories (flink root directory, release directory, flink-clone directory) and reduces usages of relative paths.
## Brief change log
* modifies source/binary release scripts to use dedicate directory for storing release artifacts
* modified rat-plugin to exclude release directory
* modified .gitignore to exclude release directory
## Verifying this change
Manually verified.
@aljoscha @tillrohrmann I'd appreciate your input.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6342
----
commit 92bf5ce764dafa82fcdc2ad3c625d194979c76d9
Author: zentol <ch...@...>
Date: 2018-07-16T13:16:19Z
[FLINK-9748][release] Use dedicated directory for release artifacts
----
---
[GitHub] flink pull request #6342: [FLINK-9748][release] Use dedicated directory for ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6342#discussion_r203629175
--- Diff: tools/releasing/create_binary_release.sh ---
@@ -44,6 +44,12 @@ else
SHASUM="sha512sum"
fi
+cd ..
+
+FLINK_DIR=`pwd`
+RELEASE_DIR=${RELEASE_DIR}/tools/releasing/release
--- End diff --
yes!
---
[GitHub] flink pull request #6342: [FLINK-9748][release] Use dedicated directory for ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6342#discussion_r203626668
--- Diff: tools/releasing/create_binary_release.sh ---
@@ -44,6 +44,12 @@ else
SHASUM="sha512sum"
fi
+cd ..
+
+FLINK_DIR=`pwd`
+RELEASE_DIR=${RELEASE_DIR}/tools/releasing/release
--- End diff --
Shouldn't this be `${FLINK_DIR}/tools/releasing/release`?
---
[GitHub] flink pull request #6342: [FLINK-9748][release] Use dedicated directory for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6342
---