You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/20 03:02:23 UTC
[GitHub] [shardingsphere] ZZemptypoint opened a new pull request, #17823: Update the priority of converting to String
ZZemptypoint opened a new pull request, #17823:
URL: https://github.com/apache/shardingsphere/pull/17823
Fixes #17821 .
Changes proposed in this pull request:
- Update the priority of converting to String
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #17823: Update the priority of converting to String
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #17823:
URL: https://github.com/apache/shardingsphere/pull/17823#issuecomment-1161255387
@ZZemptypoint Hello, any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17823: Update the priority of converting to String
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17823:
URL: https://github.com/apache/shardingsphere/pull/17823#issuecomment-1132759055
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17823?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17823](https://codecov.io/gh/apache/shardingsphere/pull/17823?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56bf1a1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/50ad6cf68ce1b11c01644c6d0f86d036bf9a60ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50ad6cf) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17823 +/- ##
=========================================
Coverage 59.12% 59.12%
Complexity 2134 2134
=========================================
Files 3599 3599
Lines 53464 53464
Branches 9118 9118
=========================================
+ Hits 31611 31612 +1
+ Misses 19173 19172 -1
Partials 2680 2680
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...here/driver/jdbc/core/resultset/ResultSetUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/17823/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvcmVzdWx0c2V0L1Jlc3VsdFNldFV0aWwuamF2YQ==) | `85.29% <100.00%> (-1.97%)` | :arrow_down: |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/17823/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17823?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17823?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50ad6cf...56bf1a1](https://codecov.io/gh/apache/shardingsphere/pull/17823?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ZZemptypoint closed pull request #17823: Update the priority of converting to String
Posted by GitBox <gi...@apache.org>.
ZZemptypoint closed pull request #17823: Update the priority of converting to String
URL: https://github.com/apache/shardingsphere/pull/17823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #17823: Update the priority of converting to String
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #17823:
URL: https://github.com/apache/shardingsphere/pull/17823#issuecomment-1161257774
@ZZemptypoint What's the different of the change? `LocalDateTime` and `String` should be independent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org