[GitHub] [trafficcontrol] TaylorCFrey commented on a change in pull request #6311: Traffic Ops scripts: Do not set GOPATH

[GitBox <gi...@apache.org>]

TaylorCFrey commented on a change in pull request #6311:
URL: https://github.com/apache/trafficcontrol/pull/6311#discussion_r747603506



##########
File path: traffic_ops/etc/profile.d/traffic_ops.sh
##########
@@ -12,11 +12,4 @@
 # limitations under the License.
 #
 
-TO_DIR="/opt/traffic_ops/app"; export TO_DIR
-
-# Setup GOPATH
-GOPATH="/opt/traffic_ops/go"; export GOPATH
-GOBIN=$GOPATH/bin
-
-# Setup PATH
-PATH=$PATH:$GOBIN:/usr/local/go/bin

Review comment:
       Do we still need to retain the GOBIN env var in PATH? Or was that only a dependency because of the GOPATH?

##########
File path: traffic_ops/etc/profile.d/traffic_ops.sh
##########
@@ -12,11 +12,4 @@
 # limitations under the License.
 #
 
-TO_DIR="/opt/traffic_ops/app"; export TO_DIR
-
-# Setup GOPATH
-GOPATH="/opt/traffic_ops/go"; export GOPATH
-GOBIN=$GOPATH/bin
-
-# Setup PATH
-PATH=$PATH:$GOBIN:/usr/local/go/bin
+export TO_DIR=/opt/traffic_ops/app;

Review comment:
       Question about bash strings. Is there a benefit or reason to not used double quotes here? Or does it even matter?

##########
File path: traffic_ops/install/bin/_postinstall.pl
##########
@@ -17,8 +17,7 @@
 use lib qw(/opt/traffic_ops/install/lib /opt/traffic_ops/app/lib /opt/traffic_ops/app/local/lib/perl5);
 
 $ENV{PERL5LIB} = "/opt/traffic_ops/install/lib:/opt/traffic_ops/app/lib:/opt/traffic_ops/app/local/lib/perl5:$ENV{PERL5LIB}";
-$ENV{PATH}     = "/usr/bin:/opt/traffic_ops/go/bin:/usr/local/go/bin:/opt/traffic_ops/install/bin:$ENV{PATH}";

Review comment:
       Same as above, any reason we'd need to keep the GOBIN (`/opt/traffic_ops/go/bin`) path even though we are removing GOPATH?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org