[jira] [Comment Edited] (FLINK-11447) Deprecate "new Table(TableEnvironment, String)"

["Dian Fu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-11447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754956#comment-16754956 ] 

Dian Fu edited comment on FLINK-11447 at 1/29/19 12:29 PM:
-----------------------------------------------------------

Thanks [~twalthr] for creating the ticket and [~sunjincheng121] for the detailed solution. Personally I like the approach 2 for the following reasons:
 1) Regarding to approach 1, personally I think *tableEnv.scan* is more suitable for a source table from the literal point of view.  It's not straight forward for *TableFunction.*
 2) Regarding to approach 3, table join table may be more straight forward which is the solution of approach 2.


was (Author: dian.fu):
Thanks [~twalthr] for creating the ticket and [~sunjincheng121] for the detailed solution. Personally I like the approach 2 for the following reasons:
1) Regarding to approach 1, personally I think *tableEnv.scan* is more suitable for a source table from the literal point of view.  It's not straight forward for *TableFunction.*
2) Regarding to approach 3, table join table may be more straight forward compared to approach 2.

> Deprecate "new Table(TableEnvironment, String)"
> -----------------------------------------------
>
>                 Key: FLINK-11447
>                 URL: https://issues.apache.org/jira/browse/FLINK-11447
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: sunjincheng
>            Priority: Major
>
> A more detailed description can be found in [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions].
> Once table is an interface we can easily replace the underlying implementation at any time. The constructor call prevents us from converting it into an interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)