You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2015/02/19 00:55:32 UTC
Review Request 31169: Patch for KAFKA-1729
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1729
https://issues.apache.org/jira/browse/KAFKA-1729
Repository: kafka
Description
-------
Add constructor to javaapi to allow constructing explicitly versioned offset fetch request
Diffs
-----
core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 1c25aa3332f9e4f0222db715b524d9179b5306cf
Diff: https://reviews.apache.org/r/31169/diff/
Testing
-------
Thanks,
Joel Koshy
Re: Review Request 31169: Patch for KAFKA-1729
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/#review73053
-----------------------------------------------------------
core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala
<https://reviews.apache.org/r/31169/#comment119227>
Do you need to fix this too?
- Jun Rao
On Feb. 18, 2015, 11:55 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31169/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:55 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1729
> https://issues.apache.org/jira/browse/KAFKA-1729
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Add constructor to javaapi to allow constructing explicitly versioned offset fetch request
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 1c25aa3332f9e4f0222db715b524d9179b5306cf
>
> Diff: https://reviews.apache.org/r/31169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 31169: Patch for KAFKA-1729
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/#review73060
-----------------------------------------------------------
Ship it!
Ship It!
- Jun Rao
On Feb. 19, 2015, 1:30 a.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31169/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2015, 1:30 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1729
> https://issues.apache.org/jira/browse/KAFKA-1729
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Allow constructing explicitly versioned offset fetch request in javaapi
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 1c25aa3332f9e4f0222db715b524d9179b5306cf
>
> Diff: https://reviews.apache.org/r/31169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 31169: Patch for KAFKA-1729
Posted by Joel Koshy <jj...@gmail.com>.
> On Feb. 19, 2015, 1:32 a.m., Jun Rao wrote:
> > core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala, line 47
> > <https://reviews.apache.org/r/31169/diff/2/?file=868598#file868598line47>
> >
> > Should we remove the comment?
Thanks - yes will do that on check-in if everything else looks good to you.
- Joel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/#review73057
-----------------------------------------------------------
On Feb. 19, 2015, 1:30 a.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31169/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2015, 1:30 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1729
> https://issues.apache.org/jira/browse/KAFKA-1729
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Allow constructing explicitly versioned offset fetch request in javaapi
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 1c25aa3332f9e4f0222db715b524d9179b5306cf
>
> Diff: https://reviews.apache.org/r/31169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 31169: Patch for KAFKA-1729
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/#review73057
-----------------------------------------------------------
core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala
<https://reviews.apache.org/r/31169/#comment119242>
Should we remove the comment?
- Jun Rao
On Feb. 19, 2015, 1:30 a.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31169/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2015, 1:30 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1729
> https://issues.apache.org/jira/browse/KAFKA-1729
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Allow constructing explicitly versioned offset fetch request in javaapi
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 1c25aa3332f9e4f0222db715b524d9179b5306cf
>
> Diff: https://reviews.apache.org/r/31169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 31169: Patch for KAFKA-1729
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/
-----------------------------------------------------------
(Updated Feb. 19, 2015, 1:30 a.m.)
Review request for kafka.
Bugs: KAFKA-1729
https://issues.apache.org/jira/browse/KAFKA-1729
Repository: kafka
Description (updated)
-------
Allow constructing explicitly versioned offset fetch request in javaapi
Diffs (updated)
-----
core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 1c25aa3332f9e4f0222db715b524d9179b5306cf
Diff: https://reviews.apache.org/r/31169/diff/
Testing
-------
Thanks,
Joel Koshy
Re: Review Request 31169: Patch for KAFKA-1729
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/#review73056
-----------------------------------------------------------
core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala
<https://reviews.apache.org/r/31169/#comment119238>
ack - yes. thanks for catching that.
- Joel Koshy
On Feb. 18, 2015, 11:55 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31169/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:55 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1729
> https://issues.apache.org/jira/browse/KAFKA-1729
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Add constructor to javaapi to allow constructing explicitly versioned offset fetch request
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 1c25aa3332f9e4f0222db715b524d9179b5306cf
>
> Diff: https://reviews.apache.org/r/31169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>